-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x11-misc/xfe: bump to version 1.44 #25263
Conversation
Pull Request assignmentSubmitter: @kernlpanic x11-misc/xfe: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 836834 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-04-29 23:56 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
x11-misc/xfe/xfe-1.44.ebuild
Outdated
src_prepare() { | ||
default | ||
|
||
cat >po/POTFILES.skip <<-EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing die
x11-misc/xfe/xfe-1.44.ebuild
Outdated
inherit plocale xdg-utils | ||
|
||
DESCRIPTION="MS-Explorer-like minimalist file manager for X" | ||
HOMEPAGE="http://roland65.free.fr/xfe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkgcheck reports a permanent redirect: Should have a trailing slash.
RedirectedUrl: version 1.44: HOMEPAGE: permanently redirected: http://roland65.free.fr/xfe -> http://roland65.free.fr/xfe/
x11-misc/xfe/xfe-1.44.ebuild
Outdated
IUSE="debug nls startup-notification" | ||
|
||
RDEPEND=" | ||
media-libs/libpng:0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this dependency still required?
x11-libs/libX11 | ||
x11-libs/libXft | ||
startup-notification? ( x11-libs/startup-notification ) | ||
" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misses
media-libs/fontconfig
x11-libs/libXrandr
x11-libs/libxcb:=
x11-libs/xcb-util
Courtesy of app-portage/iwdevtools
. You may want to look into that tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the tipp :D when I use qa-vdb It just tells me about media-libs/fontconfig and x11-libs/libXrandr. Did you use something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the deps only appear with specific USE flags enabled.
ping @kernlpanic |
sry I didn't see that somebody answered |
Closes: https://bugs.gentoo.org/836834 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Dennis Eisele <kernlpanic@dennis-eisele.de>
Pull request CI reportReport generated at: 2022-05-14 15:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
${RDEPEND} | ||
virtual/pkgconfig | ||
nls? ( | ||
dev-util/intltool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be needed even without '+nls'
.
x11-libs/libX11 | ||
x11-libs/libXft | ||
startup-notification? ( x11-libs/startup-notification ) | ||
" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the deps only appear with specific USE flags enabled.
pkg_postinst() { | ||
xdg_desktop_database_update | ||
} | ||
|
||
pkg_postrm() { | ||
xdg_desktop_database_update | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could get rid of these lines by just inheriting xdg.eclass, which will run these phases automatically.
Closes: https://bugs.gentoo.org/836834
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Dennis Eisele kernlpanic@dennis-eisele.de