Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11-misc/xfe: bump to version 1.44 #25263

Closed
wants to merge 1 commit into from

Conversation

kernlpanic
Copy link
Contributor

Closes: https://bugs.gentoo.org/836834
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Dennis Eisele kernlpanic@dennis-eisele.de

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @kernlpanic
Areas affected: ebuilds
Packages affected: x11-misc/xfe

x11-misc/xfe: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 836834


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 29, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-04-29 23:56 UTC
Newest commit scanned: 87e52d8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/967e4ad89c/output.html

src_prepare() {
default

cat >po/POTFILES.skip <<-EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing die

inherit plocale xdg-utils

DESCRIPTION="MS-Explorer-like minimalist file manager for X"
HOMEPAGE="http://roland65.free.fr/xfe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgcheck reports a permanent redirect: Should have a trailing slash.

  RedirectedUrl: version 1.44: HOMEPAGE: permanently redirected: http://roland65.free.fr/xfe -> http://roland65.free.fr/xfe/

IUSE="debug nls startup-notification"

RDEPEND="
media-libs/libpng:0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency still required?

x11-libs/libX11
x11-libs/libXft
startup-notification? ( x11-libs/startup-notification )
"
Copy link
Member

@Flowdalic Flowdalic May 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misses

media-libs/fontconfig
x11-libs/libXrandr
x11-libs/libxcb:=
x11-libs/xcb-util

Courtesy of app-portage/iwdevtools. You may want to look into that tool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tipp :D when I use qa-vdb It just tells me about media-libs/fontconfig and x11-libs/libXrandr. Did you use something else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the deps only appear with specific USE flags enabled.

@thesamesam
Copy link
Member

ping @kernlpanic

@kernlpanic
Copy link
Contributor Author

sry I didn't see that somebody answered

Closes: https://bugs.gentoo.org/836834
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Dennis Eisele <kernlpanic@dennis-eisele.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-14 15:12 UTC
Newest commit scanned: 196de37
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d621dc1273/output.html

@thesamesam thesamesam requested a review from Flowdalic May 19, 2022 02:14
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

${RDEPEND}
virtual/pkgconfig
nls? (
dev-util/intltool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be needed even without '+nls'.

x11-libs/libX11
x11-libs/libXft
startup-notification? ( x11-libs/startup-notification )
"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the deps only appear with specific USE flags enabled.

Comment on lines +70 to +76
pkg_postinst() {
xdg_desktop_database_update
}

pkg_postrm() {
xdg_desktop_database_update
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could get rid of these lines by just inheriting xdg.eclass, which will run these phases automatically.

@kernlpanic kernlpanic deleted the x11-misc/xfe branch June 28, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants