Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acct-user/cron: Sets home owner and home perms, so that users have to be #32630

Closed
wants to merge 1 commit into from
Closed

acct-user/cron: Sets home owner and home perms, so that users have to be #32630

wants to merge 1 commit into from

Conversation

lima-limon-inc
Copy link
Contributor

in cron group to use cron

Bug: https://bugs.gentoo.org/913346
From: Brian Evans grknight@gentoo.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @lima-limon-inc
Areas affected: ebuilds
Packages affected: acct-user/cron

acct-user/cron: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 913346


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 5, 2023
@lima-limon-inc
Copy link
Contributor Author

lima-limon-inc commented Sep 5, 2023

I tried to use the "From" tag to indicate that the patch comes entirely from Brian Evans. I did not author the patch; I simply submitted it. I used "From" instead of "Co-developed" tag because "Co-developed" is an under statement.
The full discussion is in the $Bug link.

PS: What is the appropriate tag in cases like these?

@floppym
Copy link
Contributor

floppym commented Sep 5, 2023

If you want to give him the credit, you could set the author on the commit to Brian's name/email using git commit --author="Brian Evans <grknight@gentoo.org>".

@lima-limon-inc
Copy link
Contributor Author

lima-limon-inc commented Sep 5, 2023

If you want to give him the credit, you could set the author on the commit to Brian's name/email using git commit --author="Brian Evans <grknight@gentoo.org>".

Noted. Thanks for the tip 😊
Is there a change this now that the commit has been committed?

in cron group to use cron

Bug: https://bugs.gentoo.org/913346
From: Brian Evans <grknight@gentoo.org>
Signed-off-by: Tomas Fabrizio Orsi <torsi@fi.uba.ar>
@floppym
Copy link
Contributor

floppym commented Sep 5, 2023

You can update the existing commit using git commit --amend --author=.... Then force push the branch to github using git push --force.

@lima-limon-inc
Copy link
Contributor Author

lima-limon-inc commented Sep 5, 2023

Like so? I believe it worked

@floppym
Copy link
Contributor

floppym commented Sep 5, 2023

Yes, that looks right.

@lima-limon-inc
Copy link
Contributor Author

Yes, that looks right.

Thank you very much for the help.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-05 15:05 UTC
Newest commit scanned: 9ee2fcd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4121b501e7/output.html

@gentoo-bot gentoo-bot closed this in 6fd3454 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants