Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/cholmod: 3.0.14 change slot to 0/3 #34543

Closed
wants to merge 1 commit into from

Conversation

negril
Copy link
Contributor

@negril negril commented Dec 29, 2023

The .so name changed from libcholmod.so.0 to libcholmod.so.3 so we need to adjust the subslot to cause rebuilds after the upgrade.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @negril
Areas affected: ebuilds, profiles
Packages affected: sci-libs/cholmod

sci-libs/cholmod: @gentoo/sci

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Dec 29, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-29 18:42 UTC
Newest commit scanned: 284f444
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2185a3fc53/output.html

@negril negril force-pushed the sci-libs/cholmod/3.0.14_subslot branch from 284f444 to 2d37d03 Compare January 9, 2024 15:11
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-09 15:28 UTC
Newest commit scanned: 2d37d03
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c9d0a6c388/output.html

@Nowa-Ammerlaan
Copy link
Member

Version 3.0.13 and 3.0.14 have the same SONAME:

andrew@andrew-gentoo-laptop ~ % objdump -p /usr/lib64/libcholmod.so.3.0.0 | grep SONAME
SONAME               libcholmod.so.3

And version 4.0.3 has a different one, but it already has SLOT=0/4.

You are correct that the 3.x.y series should have had SLOT=0/3, but a rebuild should already be triggered I think when upgrading to the 4.x.y series since the slot changes from 0 to 0/4. If we want to retroactively fix the 3.x.y series then this would require a revision bump, but I don't think it is necessary since a rebuild should already be triggered.

@negril
Copy link
Contributor Author

negril commented Jan 10, 2024

When I install -3.0.13 now I only have a /usr/lib64/libcholmod.so.0.0.0.

https://www.portagefilelist.de/index.php?p=package&id=5298ac7113ba629bd402a2cb7c9afbc9&ps=libcholmod.so*#panchor

libcholmod.so
libcholmod.so.0
libcholmod.so.0.0.0

https://www.portagefilelist.de/index.php?p=package&id=b715d1170a265a838e1ba8fcfda874ab&ps=libcholmod.so*#panchor

libcholmod.so
libcholmod.so.0
libcholmod.so.0.0.0
libcholmod.so.3
libcholmod.so.3.0.0
libcholmod.so.3.0.0.debug

The -3.0.14 list is the result of the missing sub-slot. The rename of the so is what necessitates the rebuild.

The .so name changed from libcholmod.so.0 to libcholmod.so.3
so we need to adjust the subslot to cause rebuilds after the upgrade.

Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
@negril negril force-pushed the sci-libs/cholmod/3.0.14_subslot branch from 2d37d03 to f4b17c5 Compare June 5, 2024 15:18
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-06-05 15:36 UTC
Newest commit scanned: f4b17c5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/79a24d8ade/output.html

@Nowa-Ammerlaan Nowa-Ammerlaan self-assigned this Jun 5, 2024
@gentoo-bot gentoo-bot closed this in 9840aef Jun 5, 2024
@Nowa-Ammerlaan
Copy link
Member

Thanks 👍

@negril negril deleted the sci-libs/cholmod/3.0.14_subslot branch August 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants