Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-arch/torrentzip: add 1.1 #34849

Closed
wants to merge 2 commits into from
Closed

app-arch/torrentzip: add 1.1 #34849

wants to merge 2 commits into from

Conversation

miller-alex
Copy link
Contributor

New release with a bunch of fixes.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @miller-alex
Areas affected: ebuilds
Packages affected: app-arch/torrentzip

app-arch/torrentzip: @miller-alex, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jan 16, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-17 00:17 UTC
Newest commit scanned: d35983a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e849572c48/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-17 16:23 UTC
Newest commit scanned: 8df9a03
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9482fc85b8/output.html

@miller-alex
Copy link
Contributor Author

ping

@miller-alex
Copy link
Contributor Author

5 weeks and still not merged…

Anyway, 1.2 is already out and I'm adding it here in a minute.
Should be our next stable candidate unless serious bugs surface.

@mgorny mgorny self-assigned this Feb 22, 2024
mgorny
mgorny requested changes Feb 22, 2024
View reviewed changes
app-arch/torrentzip/torrentzip-1.1.ebuild
@@ -1,4 +1,4 @@
# Copyright 1999-2023 Gentoo Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. Let's skip 1.1 then, and go straight for 1.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The push 2 days ago should address all your suggestions, but the "changes requested" warning doesn't go away. You attached this comment to a line which didn't change.

app-arch/torrentzip/torrentzip-1.2.ebuild Outdated Show resolved Hide resolved
app-arch/torrentzip/torrentzip-1.2.ebuild Outdated Show resolved Hide resolved
app-arch/torrentzip/torrentzip-1.2.ebuild Outdated Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-22 18:35 UTC
Newest commit scanned: e7a4b40
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c0f46686a0/output.html

@miller-alex
app-arch/torrentzip: add 1.2
c37829e 
Update LICENSE clarified upstream.
Drop src_configure() since OF() macro is finally gone.
Looks like a good stable candidate (so we can drop 0.9-r1 for #920358).

Bug: https://bugs.gentoo.org/920358
Signed-off-by: Alexander Miller <alex.miller@gmx.de>
@miller-alex
app-arch/torrentzip: drop 1.0
dd22a57 
Signed-off-by: Alexander Miller <alex.miller@gmx.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-22 19:22 UTC
Newest commit scanned: dd22a57
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cbf93255c3/output.html

mgorny
mgorny approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@miller-alex miller-alex deleted the torrentzip-1.1 branch March 5, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees

@mgorny mgorny

Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miller-alex @gentoo-bot @gentoo-repo-qa-bot @mgorny