Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-plugins/calf: work around buggy configure check #9701

Closed
wants to merge 1 commit into from
Closed

media-plugins/calf: work around buggy configure check #9701

wants to merge 1 commit into from

Conversation

haasn
Copy link
Contributor

@haasn haasn commented Aug 26, 2018

The upstream project's configure.ac hard-codes a check to see if calf is
already installed to /usr/lib or /usr/local/lib, and if so, refuses to
configure (causing econf to fail) if calf is already installed on the
system.

Simply adding --without-obsolete-check to the configure invocation
disables this (pointless) check.

@haasn
Copy link
Contributor Author

haasn commented Aug 26, 2018

It's worth pointing out that 0.0.60 does not have this behavior (nor this option), which is why I didn't touch that ebuild.

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. labels Aug 26, 2018
@haasn
Copy link
Contributor Author

haasn commented Oct 19, 2018

Any update on this? calf still fails building on my end due to this issue.

@haasn
media-plugins/calf: work around buggy configure check
d5d9002 
The upstream project's configure.ac hard-codes a check to see if calf is
already installed to /usr/lib or /usr/local/lib, and if so, refuses to
configure (causing econf to fail) if `calf` is already installed on the
system.

Simply adding --without-obsolete-check to the configure invocation
disables this (pointless) check.

Closes: https://bugs.gentoo.org/669016
Signed-off-by: Niklas Haas <git@haasn.xyz>
@haasn
Copy link
Contributor Author

haasn commented Oct 19, 2018

I've created an upstream bug and linked it in the commit.

@haasn haasn changed the title media-plugins/calf: work around buggy configure check media-plugins/calf: work around buggy configure check [please reassign] Oct 19, 2018
@gentoo-bot gentoo-bot changed the title media-plugins/calf: work around buggy configure check [please reassign] media-plugins/calf: work around buggy configure check Oct 19, 2018
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: media-plugins/calf

media-plugins/calf: [proaudio (project)]

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 669016

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. labels Oct 19, 2018
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-10-19 13:36 UTC
Newest commit scanned: d5d9002
Status: ✅ good

No issues found

@fordfrog
Copy link
Contributor

thank you for investigating the issue and providing the patch! :-) i'm not maintainer of calf but i took the chance to fix it as it did not attract enough attention since you created the pr :-)

commit 960290b4d4b2dc8c06e9cd08297b3e724c9ac67a
Author: Niklas Haas <git@haasn.xyz>
Date:   Sun Aug 26 18:28:06 2018 +0200

    media-plugins/calf: work around buggy configure check
    
    The upstream project's configure.ac hard-codes a check to see if calf is
    already installed to /usr/lib or /usr/local/lib, and if so, refuses to
    configure (causing econf to fail) if `calf` is already installed on the
    system.
    
    Simply adding --without-obsolete-check to the configure invocation
    disables this (pointless) check.
    
    Closes: https://bugs.gentoo.org/661036
    Closes: https://github.com/gentoo/gentoo/pull/9701
    Signed-off-by: Niklas Haas <git@haasn.xyz>
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

@fordfrog fordfrog closed this Jan 26, 2019
gentoo-bot pushed a commit that referenced this pull request Jan 26, 2019
@haasn @fordfrog
media-plugins/calf: work around buggy configure check
960290b 
The upstream project's configure.ac hard-codes a check to see if calf is
already installed to /usr/lib or /usr/local/lib, and if so, refuses to
configure (causing econf to fail) if `calf` is already installed on the
system.

Simply adding --without-obsolete-check to the configure invocation
disables this (pointless) check.

Closes: https://bugs.gentoo.org/661036
Closes: #9701
Signed-off-by: Niklas Haas <git@haasn.xyz>
Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
Milestone
No milestone
4 participants
@haasn @gentoo-bot @gentoo-repo-qa-bot @fordfrog