-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-qt/qtwayland: make compositor APIs off-by-default optional #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not get to testing yet either, but no objections from me after just a look-see.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections.
Of course, the decision to drop IUSE=vulkan leads to the following issues:
Maybe just mask qtwayland:5[compositor] on these arches in addition to vulkan. |
Would have preferred a clean split but wayland-server depends on wayland-client in the buildsys. - Drop IUSE vulkan: Merge with 'compositor' instead. This absolves us from having to make a default conflicting REQUIRED_USE with compositor. - Drop IUSE X: Unused, broken upstream since 2021 and removed in Qt6. Quoting upstream from commit d4a7faff: "These plugins were created to allow testing/debugging of QtWayland- based compositors on desktops that did not support Wayland natively." Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
c8a3ffb
to
caf38f7
Compare
Yup, down to this after cleaning up obsolete package.use.mask entries in ::gentoo:
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Would have preferred a clean split but wayland-server depends on wayland-client in the buildsys.
PS: Not runtime tested yet.