dev-cpp/blitz: 1.0.3_pre fix boost, doxygen dependencies #1065

band-a-prend · 2021-03-14T21:00:14Z

The blitz-1.0.2_p20200524 provides libblitz.so.1.0.3 therefore
the new ebuild is renamed to blitz-1.0.3_pre20200524 instead of revision bump while both use the same git-commit-sha-tarball.
Blitz++ optionally depends on dev-libs/boost[static-libs]
to allow build with Boost::serialization support
(note: cmake option is realy with typo).
USE="boost" is used to handle this option.
Add USE="doc" app-doc/doxygen[dot] build dependency to build dev docs.
Add python build time dependency.
The testsuite, benchmark, examples targets now is only conditionally build
in src_compile() and tests are ran in implicit src_test() phase.
Update live ebuild.

band-a-prend · 2021-03-15T12:53:59Z

It's seems that using of boost serialization is optional, so it's need to define with use flag.

epsilon-0

Thanks a lot.
Have left a few comments.

Squash both commits into one.

Drop the previous version of the dated ebuild, in a separate commit.

epsilon-0 · 2021-03-15T13:49:04Z

dev-cpp/blitz/blitz-1.0.2_p20200524-r1.ebuild

+src_prepare() {
+	default
+	# provide "libblitz-1.0.2.so" instead of "libblitz-1.0.3.so"
+	sed -i -e "s/blitz_PATCH 3/blitz_PATCH 2/" CMakeLists.txt || die


lets not do this, there's no specific reason and does not provide any benefit,

It slightly confuse me that package is 1.0.2 but installed library is 1.0.3.
Maybe then to rename ebuild to blitz-1.0.3_pre20200524, isn't?
And then to drop old dated ebuild.

That sounds good 👍

epsilon-0 · 2021-03-15T13:49:23Z

dev-cpp/blitz/blitz-1.0.2_p20200524-r1.ebuild

+BDEPEND="${PYTHON_DEPS}"
+DEPEND="
+	dev-libs/boost:=
+	doc? ( app-doc/doxygen[dot] )


doxygen needs to be in BDEPEND.

epsilon-0 · 2021-03-15T13:50:09Z

dev-cpp/blitz/blitz-1.0.2_p20200524-r1.ebuild

+}
+
+src_compile() {
+	cmake_build


cmake_src_compile

Done. With addition of conditionally compiled doc and test targets.

epsilon-0 · 2021-03-15T13:50:37Z

dev-cpp/blitz/blitz-1.0.2_p20200524-r1.ebuild

+}
+
+src_test() {
+	cmake_build check-testsuite check-benchmarks check-examples


does it not need cmake_src_test?

cmake_src_test tries to run precompiled testsuite, benchmark and examples tests. So the build of this targets is placed in src_compile() under appropriate condition.

band-a-prend · 2021-03-16T15:58:38Z

Boost::serialization support requires dev-libs/boost[static-libs] as it is checked in src/CMakeLists.txt if it's static library is presented in system.

Nowa-Ammerlaan · 2021-03-16T16:05:35Z

Boost::serialization support requires dev-libs/boost[static-libs] as it is checked in src/CMakeLists.txt if it's static library is presented in system.

Sometimes you can just sed s/.a/.so/g in those cases (and sometimes that will break everything)

band-a-prend · 2021-03-16T16:28:23Z

Sometimes you can just sed s/.a/.so/g in those cases (and sometimes that will break everything)

This option is used and affected this

set(Boost_USE_STATIC_LIBS        ON) # only find static libs

The blitz unconditionally provides static library build that also build in boost::serialization in case under review.

In some cases static linking is usefull in scientific application then it build on platform with differ runtime and use just to run on other system. I'm not a fan of this approach but I encountered such case several times.

thesamesam · 2021-03-19T04:20:06Z

dev-cpp/blitz/blitz-1.0.3_pre20200524.ebuild

+
+EAPI=7
+
+CMAKE_MAKEFILE_GENERATOR=emake


We really need this? :(

Usually it requires if Fortran code is compiled. I.e. Sundials had compilation problems with ninja.

In blitz++ the Fortran compiler is required only optionally to build fortran benckmark that is used to compare speed of blitz++ with pure fortran array operations.

In this ebuild this benchmark isn't built so maybe blitz++ could use ninja. I need to recheck it.

thesamesam · 2021-03-19T04:20:33Z

dev-cpp/blitz/blitz-1.0.3_pre20200524.ebuild

+DESCRIPTION="Multi-dimensional array library for C++"
+HOMEPAGE="https://github.com/blitzpp/blitz"
+
+COMMIT=39f885951a9b8b11f931f917935a16066a945056


Standard structure has DESCRIPTION/HOMEPAGE/SRC_URI/S together, then a blank newline, then LICENSE/SLOT/KEYWORDS/IUSE/RESTRICT.

I'd also quote COMMIT and put it above DESCRIPTION.

epsilon-0 · 2021-03-16T17:04:08Z

dev-cpp/blitz/blitz-1.0.3_pre20200524.ebuild

+		-DBUILD_TESTING=$(usex test)
+		-DBUILD_DOC=$(usex doc)
+	)
+	use boost && mycmakeargs+=( -DENABLE_SERIALISATION=ON )


add it to the original list with -DENABLE_SERIALISATION=$(usex boost)

The blitz-1.0.2_p20200524 provides libblitz.so.1.0.3 therefore the new ebuild is renamed to *-1.0.3_pre20200524 instead of revision bump while both use the same git-commit-sha-tarball. Blitz++ optionally depends on dev-libs/boost[static-libs] to allow build with Boost::serialization support (note: cmake option is realy with typo). USE="boost" is used to handle this option. Add USE="doc" app-doc/doxygen build dependency to build dev docs. Add python build time dependency. The testsuite, benchmark, examples targets now is only conditionally build in src_compile() and tests are ran in implicit src_test() phase. Update live ebuild. Signed-off-by: band-a-prend <torokhov-s-a@yandex.ru>

Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>

epsilon-0 · 2021-03-20T12:32:59Z

I have to fix my gentoo machine and will merge this when I get it fixed ❤️

band-a-prend · 2021-04-13T14:27:28Z

@epsilon-0
Ping!

epsilon-0 · 2021-04-20T15:44:52Z

thanks! merged :D

epsilon-0 reviewed Mar 15, 2021

View reviewed changes

band-a-prend changed the title ~~dev-cpp/blitz: 1.0.2 fix boost, doxygen dependencies~~ dev-cpp/blitz: 1.0.3_pre fix boost, doxygen dependencies Mar 16, 2021

thesamesam reviewed Mar 19, 2021

View reviewed changes

epsilon-0 reviewed Mar 19, 2021

View reviewed changes

band-a-prend added 2 commits March 19, 2021 15:50

dev-cpp/blitz: drop replaced blitz-1.0.2_p20200524.ebuild

c3a4380

Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>

gentoo-bot closed this in 176df3f Apr 20, 2021

band-a-prend deleted the blitz branch April 21, 2021 15:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-cpp/blitz: 1.0.3_pre fix boost, doxygen dependencies #1065

dev-cpp/blitz: 1.0.3_pre fix boost, doxygen dependencies #1065

band-a-prend commented Mar 14, 2021 •

edited

Loading

band-a-prend commented Mar 15, 2021

epsilon-0 left a comment •

edited

Loading

epsilon-0 Mar 15, 2021

band-a-prend Mar 15, 2021

epsilon-0 Mar 15, 2021

band-a-prend Mar 16, 2021

epsilon-0 Mar 15, 2021

band-a-prend Mar 16, 2021

epsilon-0 Mar 15, 2021

band-a-prend Mar 16, 2021

epsilon-0 Mar 15, 2021

band-a-prend Mar 16, 2021

band-a-prend commented Mar 16, 2021

Nowa-Ammerlaan commented Mar 16, 2021 •

edited

Loading

band-a-prend commented Mar 16, 2021

thesamesam Mar 19, 2021

band-a-prend Mar 19, 2021

thesamesam Mar 19, 2021

thesamesam Mar 19, 2021

epsilon-0 Mar 16, 2021

band-a-prend Mar 19, 2021

epsilon-0 commented Mar 20, 2021

band-a-prend commented Apr 13, 2021

epsilon-0 commented Apr 20, 2021


		EAPI=7

		CMAKE_MAKEFILE_GENERATOR=emake

dev-cpp/blitz: 1.0.3_pre fix boost, doxygen dependencies #1065

dev-cpp/blitz: 1.0.3_pre fix boost, doxygen dependencies #1065

Conversation

band-a-prend commented Mar 14, 2021 • edited Loading

band-a-prend commented Mar 15, 2021

epsilon-0 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

band-a-prend commented Mar 16, 2021

Nowa-Ammerlaan commented Mar 16, 2021 • edited Loading

band-a-prend commented Mar 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

epsilon-0 commented Mar 20, 2021

band-a-prend commented Apr 13, 2021

epsilon-0 commented Apr 20, 2021

band-a-prend commented Mar 14, 2021 •

edited

Loading

epsilon-0 left a comment •

edited

Loading

Nowa-Ammerlaan commented Mar 16, 2021 •

edited

Loading