scripts/setup-and-run-repoman.sh: use 'sort -V' to get latest tag #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the -V flag to enable version sort, 'sort' can falsely identify a version string like 3.0.9 to be greater than 3.0.10. This can be shown by running 'git tag | grep portage | sort -u' in the Portage Git tree. This issue is not so prominent for repoman yet because the latest version of repoman as of now is 3.0.3, but it will surface when repoman 3.0.10 is released. Signed-off-by: Yuan Liao <liaoyuan@gmail.com>
gentoo-bot
pushed a commit
to gentoo/guru
that referenced
this pull request
Jun 15, 2021
Without the -V flag to enable version sort, 'sort' can falsely identify a version string like 3.0.9 to be greater than 3.0.10. This can be shown by running 'git tag | grep portage | sort -u' in the Portage Git tree. This issue is not so prominent for repoman yet because the latest version of repoman as of now is 3.0.3, but it will surface when repoman 3.0.10 is released. Signed-off-by: Yuan Liao <liaoyuan@gmail.com> Closes: gentoo/sci#1094 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
|
Thanks, good catch, I went ahead and applied the same patch to ::guru as well. |
Nowa-Ammerlaan
pushed a commit
to Nowa-Ammerlaan/natinst
that referenced
this pull request
Jun 15, 2021
Without the -V flag to enable version sort, 'sort' can falsely identify a version string like 3.0.9 to be greater than 3.0.10. This can be shown by running 'git tag | grep portage | sort -u' in the Portage Git tree. This issue is not so prominent for repoman yet because the latest version of repoman as of now is 3.0.3, but it will surface when repoman 3.0.10 is released. Signed-off-by: Yuan Liao <liaoyuan@gmail.com> Closes: gentoo/sci#1094 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scripts/setup-and-run-repoman.shscript uses thesortprogram to get the latest repoman release from the Portage Git tree, but without the-Voption, it can falsely identify versions like2.3.9to be newer than2.3.10:The script should still work fine now because it might take a while for repoman to get to 3.0.10, but once that happens, it will become a minor issue.
Note that the copy of this script under
gentoo/guruhas this issue too. If you would like me to submit another pull request for that one as well, please let me know!