-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-physics/spheno: add 4.0.5 #1254
Conversation
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
src_compile() { | ||
# single thread force needed since fortan mods depend on each other | ||
export MAKEOPTS=-j1 | ||
export MAKEOPTS="$MAKEOPTS -j1" | ||
tc-export FC AR | ||
emake AR="${AR}" F90="${FC}" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src_compile() {
# single thread force needed since fortan mods depend on each other
tc-export FC AR
emake -j1 AR="${AR}" F90="${FC}"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also seems a bit double to both tc-export
and set the variables explicitly in the emake
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally fortran-2
would set it but we need to overwrite F90
by FC
. I am not sure if AR
is really needed, but I guess there was a reason for setting it a year ago :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally
fortran-2
would set it but we need to overwriteF90
byFC
.
But then the tc-export
is not required I think.
I am not sure if
AR
is really needed, but I guess there was a reason for setting it a year ago :/
Yes there usually is a reason, but sometimes the reason is "If I change this, I have to test it and verify that it is not broken now and I don't have time to do that at the moment".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in this case it was a single PR adding AR #1162
Maybe it should be ${AR}
instead of $(AR)
in the patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way I am testing it now.
PR created by pkgpr.