Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sci-visualization/scidavis: Qt5 data visualizer and analyzer #984

Closed
wants to merge 3 commits into from
Closed

Sci-visualization/scidavis: Qt5 data visualizer and analyzer #984

wants to merge 3 commits into from

Conversation

Nowa-Ammerlaan
Copy link
Member

Hi,

I wrote this ebuild for scidavis (it's like Origin but FOSS), and I thought the science overlay would be the fitting place for it. It requires two new dependencies. One is a qt5 fork of an older version of qwt-5 (qwt5-qt5, packaged as qwt:5). The other is qwtplot3d which was previously maintained by the science team in ::gentoo, but was removed for not being qt5 compatible, however, thanks to some small patches form the AUR this actually works just fine with qt5. Both the qwt:5 and qwtplot3d ebuilds are heavily based on the ebuilds previously in ::gentoo, the scidavis ebuild was written from scratch.

Relevant commits to ::gentoo dropping qwtplot3d and qwt:5: gentoo/gentoo@3b7c44c and gentoo/gentoo@34cbddb

Please let me know what you think of these ebuilds

@epsilon-0
Copy link
Contributor

This is a large one 😺
Gonna take some time to go through this but it looks interesting ❤️

@Nowa-Ammerlaan
Copy link
Member Author

Just made some final finishing touches, added a missing einstalldocs and fixed some indentation

Copy link
Contributor

@epsilon-0 epsilon-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There quite a lot of patches here.
Can you enable tests for these packages so that we have some sanity checking?

sci-visualization/scidavis/scidavis-2.3.0.ebuild Outdated Show resolved Hide resolved
sci-visualization/scidavis/scidavis-2.3.0.ebuild Outdated Show resolved Hide resolved
sci-visualization/scidavis/scidavis-2.3.0.ebuild Outdated Show resolved Hide resolved
x11-libs/qwt/qwt-5.2.3_p20200902.ebuild Outdated Show resolved Hide resolved
x11-libs/qwt/qwt-5.2.3_p20200902.ebuild Outdated Show resolved Hide resolved
x11-libs/qwtplot3d/qwtplot3d-0.2.7.ebuild Outdated Show resolved Hide resolved
named same as qwt-6, but in seperate slot so they can be
installed simulataniously

based on the treecleaned 5.2.3 ebuild (2018 06 28)
gentoo/gentoo@34cbddb

Package-Manager: Portage-3.0.8, Repoman-3.0.2
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
@Nowa-Ammerlaan
Copy link
Member Author

There quite a lot of patches here.
Can you enable tests for these packages so that we have some sanity checking?

As far as I know there aren't any upstream tests in the tarball, there are some examples, but getting them to work will likely require more patching. Scidavis itself does have tests though, and they pass, so that at least indicates that qwtplot3d is functional in scidavis.

The -qt-4.8.0 patch makes qwtplot3d work with Qt4.8 and up, including Qt5, the patch is from the AUR
The -gcc44 patch makes qwtplot3d work with newer gcc, and is both in the AUR and in the former ::gentoo ebuild
The other patches are all copied from the former ::gentoo ebuild.
The -profile patch seems to fix the version number and remove the debug flag from CONFIG.
The -gl2ps patch makes qwtplot3d build against the system version of gl2ps, instead of the one bundled in the 3rdparty directory.
The -doxygen patch presumably fixes the compilation of the docs, though I'm unsure what exactly it is doing.
The -examples patch presumably makes the examples work outside of the source tarball, similarly to what the code behind if use examples is doing in the qwt ebuild.

@epsilon-0
Copy link
Contributor

I'll test this on the weekend. I'm a bit busy atm.

@Nowa-Ammerlaan
Copy link
Member Author

@epsilon-0 Any news on this?

@Nowa-Ammerlaan
Copy link
Member Author

I just discovered that the USE flags were not applying correctly. E.g. with USE=origin the support for origin files was not actually enabled. I fixed that now by using the usex function instead. Then I discovered a bug in the tests (because CONFIG+=test was now applying correctly) and fixed that too https://github.com/highperformancecoder/scidavis/pull/155

@epsilon-0
Copy link
Contributor

@AndrewAmmerlaan
Apologies I've been sick and have been resting.
Will get back to this soon.

@Nowa-Ammerlaan
Copy link
Member Author

Nowa-Ammerlaan commented Nov 8, 2020

@AndrewAmmerlaan
Apologies I've been sick and have been resting.
Will get back to this soon.

@epsilon-0 That's alright, I hope you will get better soon :)

removed from ::gentoo on 2018 02 13 for not being qt5 compatible
minor patching actually does make this work with qt5 though
patches from the original ebuild and from the AUR(for qt5 compat)

gentoo/gentoo@3b7c44c

Package-Manager: Portage-3.0.8, Repoman-3.0.2
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
Requires new deps qwtplot3d and qwt5-qt5(packaged as qwt:5)

Bug: https://bugs.gentoo.org/556832
Package-Manager: Portage-3.0.8, Repoman-3.0.2
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
@gentoo-bot gentoo-bot closed this in f068dc7 Nov 9, 2020
@Nowa-Ammerlaan Nowa-Ammerlaan deleted the sci-visualization/scidavis branch November 9, 2020 14:41
@Nowa-Ammerlaan
Copy link
Member Author

Thank you @heroxbd and @epsilon-0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants