Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of sprintf`s params in Geocoder\Model\AdminLevelCollection::checkLevel #468

Closed
bubnov-mikhail opened this issue Nov 5, 2015 · 2 comments

Comments

@bubnov-mikhail
Copy link

Now it is:
throw new \OutOfBoundsException(sprintf(
self::MAX_LEVEL_DEPTH,
"Administrative level should be an integer in [1,%d], %d given",
$level
));
//Output: 5

It should be:

throw new \OutOfBoundsException(sprintf(
"Administrative level should be an integer in [1,%d], %d given",
self::MAX_LEVEL_DEPTH,
$level
));
//Output: Administrative level should be an integer in [1,5], 6 given

@willdurand
Copy link
Member

Hi! Thanks for the report. Could you create a PR for that? Thank you!

@bubnov-mikhail
Copy link
Author

I have created the PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants