Skip to content

[LocationIQ] Normalize City #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 8, 2020
Merged

[LocationIQ] Normalize City #1038

merged 6 commits into from
Jan 8, 2020

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented Jan 8, 2020

Add normalizecity parameter in the request to make sure there is a city property in the response.
See https://locationiq.com/docs-html/index.html#locationiq-specific-parameters

Close #1037

@jbelien
Update LocationIQ.php
9212458 
Add `normalizecity` parameter in the request to make sure there is a `city` property in the response.
See https://locationiq.com/docs-html/index.html#locationiq-specific-parameters

Close #1037
@jbelien
Copy link
Member Author

jbelien commented Jan 8, 2020

@pixrr Could you confirm this fixes your "issue" ?

@pixrr
Copy link

pixrr commented Jan 8, 2020 •
edited
Loading

@pixrr Could you confirm this fixes your "issue" ?

Yes, it seems good 👍

Edit 2: It does not seem to work with the xml format 🤔 I refer this to the issue #1037

jbelien and others added 3 commits January 8, 2020 21:46
@jbelien
Update LocationIQ.php
3c9a630 
Fix issue if `country_code` is not defined.
@jbelien
Update tests and cached responses
12829d2
@jbelien
Update IntegrationTest.php
c550dcb 
Apply fixes from StyleCI
@jbelien
Copy link
Member Author

jbelien commented Jan 8, 2020

Edit 2: It does not seem to work with the xml format 🤔

Good catch!
They mention it somehow in the documentation:

This version (v1) of our Search API is compatible with OpenStreetMap's Nominatim Geocoder in both JSON & XML formats. However, all our enhancements such as additional datasets and algorithms are supported only in json or xmlv1.1 format options.

@jbelien jbelien requested review from atymic and Nyholm January 8, 2020 21:09
atymic
atymic approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jbelien jbelien merged commit f3225ad into master Jan 8, 2020
@jbelien jbelien deleted the locationiq/normalizecity branch January 8, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atymic atymic atymic approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees
No one assigned
Labels
improvement provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot get city with LocationIQ provider
3 participants
@jbelien @pixrr @atymic