Skip to content

Conversation

Spriz
Copy link
Contributor

@Spriz Spriz commented Nov 10, 2022

I'd guess this line was left out by accident - but never the less it would be nice to have it here as well :-)

@Spriz Spriz changed the title Include the postalcode in the reverse query as well Include the postalcode in the reverse query as well in TomTom provider Nov 10, 2022
@Spriz
Copy link
Contributor Author

Spriz commented Nov 10, 2022

I just copied the line from geocodeQuery() btw: https://github.com/Spriz/Geocoder/blob/patch-1/src/Provider/TomTom/TomTom.php#L102

@jbelien
Copy link
Member

jbelien commented Nov 10, 2022

Thanks a lot @Spriz 👍
Could you add the postal code to the test as well ? Thanks!

Copy link
Contributor Author

@Spriz Spriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for postal code being not-null in tests as well

@Spriz
Copy link
Contributor Author

Spriz commented Nov 11, 2022

@jbelien Done! 👍

EDIT: Since it was checking specifically for null in the tests - I wonder if there was a good reason 🤔

@jbelien jbelien merged commit 5442c34 into geocoder-php:master Nov 11, 2022
@Spriz Spriz deleted the patch-1 branch November 11, 2022 10:38
@jbelien
Copy link
Member

jbelien commented Nov 11, 2022

Thanks @Spriz !
A new release has been published: https://packagist.org/packages/geocoder-php/tomtom-provider#4.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants