Fix timed geocoder with exception flow #376
Conversation
| } | ||
|
|
||
| public function testGeocode() | ||
| { |
There was a problem hiding this comment.
It was indented using 3 spaces instead of 4. I fixed it too.
|
Is this really needed? If an exception occured, the script should stop and call the error handler. The |
|
Don't really know if it is needed. Personally, I have done the same here. It just seems strange the stopwatch is not "really" stopped when an exception is thrown whereas you want it to be stopped. Basically, this is not because there is an exception thrown then your application must stop to run. You can catch it and continue your script. |
|
I know, but now you have an wrong result. Let's say the provider isn't reachable, and the timeout from 10 seconds is reached. Now you have an entry in your timeline which says, the provider takes 10 seconds to fetch the result. I dont't think this is the right way to go. |
|
Personally, I use the stopwatch component to time good and errored requests. If my script takes 15 seconds and Geocoder takes 10 seconds, I would expect to have it timed right regardless if the request have good or not. Technically, Geocoder has been used during 10 seconds and so, I would expect it to be displayed as it in all cases... |
|
Maybe my example wasn't good enough. But i'm not against this PR, if it help some people, i'm okay with this small change. |
Fix timed geocoder with exception flow
All is in the title. Before this PR, the timed geocoder didn't stop the stopwatch component when a exception was thrown.