-
Notifications
You must be signed in to change notification settings - Fork 523
[RFC] Introduce AddressCollection class #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| <?php | ||
|
|
||
| namespace Geocoder\Model; | ||
|
|
||
| final class AddressCollection implements \IteratorAggregate, \Countable | ||
| { | ||
| /** | ||
| * @var Address[] | ||
| */ | ||
| private $addresses; | ||
|
|
||
| public function __construct(array $addresses = []) | ||
| { | ||
| $this->addresses = array_values($addresses); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| public function getIterator() | ||
| { | ||
| return new \ArrayIterator($this->all()); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| public function count() | ||
| { | ||
| return count($this->addresses); | ||
| } | ||
|
|
||
| /** | ||
| * @return Address | ||
| */ | ||
| public function first() | ||
| { | ||
| if (empty($this->addresses)) { | ||
| return null; | ||
| } | ||
|
|
||
| return reset($this->addresses); | ||
| } | ||
|
|
||
| /** | ||
| * @return Address[] | ||
| */ | ||
| public function slice($offset, $length = null) | ||
| { | ||
| return array_slice($this->addresses, $offset, $length); | ||
| } | ||
|
|
||
| /** | ||
| * @return Address | ||
| */ | ||
| public function get($index) | ||
| { | ||
| if (!isset($this->addresses[$index])) { | ||
| throw new \OutOfBoundsException(sprintf('The index "%s" does not exist in this collection.', $index)); | ||
| } | ||
|
|
||
| return $this->addresses[$index]; | ||
| } | ||
|
|
||
| /** | ||
| * @return Address[] | ||
| */ | ||
| public function all() | ||
| { | ||
| return $this->addresses; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we return null here? IIRC we can't get 0 results as it would lead to a
NoResultexception earlier in the execution flow:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think we can remove
nullhere. We always have at least oneAddressin the collection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I would not remove it since the class might be used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't thought it could used somewhere else :S