Skip to content

Removed GetLimit #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2017
Merged

Removed GetLimit #736

merged 1 commit into from
Jul 11, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 9, 2017

This will fix #733

@willdurand willdurand requested a review from Baachi July 9, 2017 15:10
@Nyholm Nyholm added this to the 4.0.0 milestone Jul 9, 2017
@willdurand
Copy link
Member

Is there any replacement for that? (sorry if it is a silly question.. )

@Nyholm
Copy link
Member Author

Nyholm commented Jul 10, 2017

Thank you for reviewing this. There are no silly questions.

I've removed the setter because we want all our providers and geocoders stateless.
I removed the getter since we do not use it internally and because having a setter to read a static configuration value does not give much use.

@Nyholm Nyholm merged commit fdde4bb into geocoder-php:master Jul 11, 2017
@Nyholm Nyholm deleted the issue-733 branch July 11, 2017 16:41
svrdlic pushed a commit to svrdlic/Geocoder that referenced this pull request Jul 16, 2017
@Nyholm @svrdlic
Removed GetLimit (geocoder-php#736)
0c446f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baachi Baachi Awaiting requested review from Baachi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Remove some public methods from ProviderAggregator
2 participants
@Nyholm @willdurand