Skip to content

Conversation

holtkamp
Copy link
Contributor

No description provided.

Allow to configure log levels
Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@atymic
Copy link
Member

atymic commented Jun 16, 2019

cc @jbelien

@holtkamp
Copy link
Contributor Author

ping @atymic and @jbelien, can this be considered for merge?

@jbelien jbelien merged commit 834b4ba into geocoder-php:master Jul 22, 2019
@holtkamp holtkamp deleted the patch-configurable-log-level branch July 22, 2019 08:13
@holtkamp
Copy link
Contributor Author

Thanks @jbelien

Does this justify a new minor release? Our logs are flooded with alert log entries when using Geocoders that do not support certain addresses (for example IP-addresses). These are known limitations and no alerts need be triggered 🤓

@jbelien
Copy link
Member

jbelien commented Jul 22, 2019

Yes, I will release a new version for the Chain provider! 🎉

But first I need to fix a (non related) issue : #983 (to be able to merge my PR about the CHANGELOG) 😕

atymic pushed a commit to atymic/Geocoder that referenced this pull request Jul 23, 2019
* Update Chain.php

Allow to configure log levels

* Do use constructor for log level defaults
@jbelien
Copy link
Member

jbelien commented Jul 23, 2019

@holtkamp Done : https://packagist.org/packages/geocoder-php/chain-provider 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants