Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider border size when calulcating popup position #293

Closed
wants to merge 1 commit into from
Closed

Consider border size when calulcating popup position #293

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 5, 2014

No description provided.

@marcjansen
Copy link
Member

Hey @sweco-sebhar, any chance you can add a test? And possibly a before/after comparison (with an image preferable?). Thanks.

@marcjansen
Copy link
Member

Is getBorderPadding private? Is it still existing in ExtJS5. No time to check now.

@marcjansen marcjansen closed this Nov 5, 2014
@marcjansen
Copy link
Member

ahhh didn't want to close, sorry.

@marcjansen marcjansen reopened this Nov 5, 2014
@ghost
Copy link
Author

ghost commented Nov 5, 2014

getBorderPadding is private but still existing in Ext JS 5 (looked it up now, wasn't aware) so I guess this might not be an acceptable solution :(

@chrismayer
Copy link
Contributor

Hey @sweco-sebhar could you offer a few more informations about the problem itself? Is the anchor position incorrect? As @marcjansen suggested a comparison-image would be nice. TIA.

@bentrm
Copy link
Member

bentrm commented Nov 14, 2014

Is this related to this?

Screenshots taken on hosted example pages.

@marcjansen
Copy link
Member

Thanks for the pictures. Let's See it this fixed by the patch.

@chrismayer
Copy link
Contributor

Thank you! I will also have a look later the day.

@chrismayer
Copy link
Contributor

I checked this and it seems that only the Neptune-theme has the described problem. Classic, Gray and Access seem to be OK.
When I apply the patch, the Neptune version still doesn't seem to be completely correct ( a bit too far to the right) and the anchors in the other theme-versions are drawn a bit to high:

293-w-applied-patch
293-w-applied-patch-classic

@marcjansen
Copy link
Member

I am closing this, since it has been quite silent for some time. Please reopen if you disagree.

@marcjansen marcjansen closed this Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants