fix: Allow user to change his email whatever the email status is

fixes #1043
geokrety · Aug 24, 2024 · 48d0bfb · 48d0bfb
1 parent c82235c
commit 48d0bfb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/tests/unit/app/GeoKrety/Emails/EmailChangeTest.php b/tests/unit/app/GeoKrety/Emails/EmailChangeTest.php
@@ -12,7 +12,7 @@ public static function emailStatusProvider(): array {
             [User::USER_EMAIL_NO_ERROR, 1],
             [User::USER_EMAIL_DOES_NOT_EXIST, 1],
             [User::USER_EMAIL_UNCONFIRMED, 1],
-            [User::USER_EMAIL_MISSING, 0],
+            [User::USER_EMAIL_MISSING, 1],
             [User::USER_EMAIL_MAILBOX_FULL, 1],
             [User::USER_EMAIL_DETECTED_AS_SPAM, 1],
         ];

diff --git a/website/app/GeoKrety/Email/EmailChange.php b/website/app/GeoKrety/Email/EmailChange.php
@@ -12,7 +12,8 @@ protected function setFromDefault() {
     }
 
     protected function allowSend(User $user): bool {
-        return $user->isEmailValidForAdminTask();
+        // Allow user to change their mail address, whatever the status is
+        return true;
     }
 
     protected function allowNonProdEnvSend(): bool {