Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid results and tab results behave differently #95

Closed
elil opened this issue May 29, 2017 · 9 comments
Closed

Grid results and tab results behave differently #95

elil opened this issue May 29, 2017 · 9 comments

Comments

@elil
Copy link
Member

elil commented May 29, 2017

Hovering over grid results highlights that particular parcel in the selection. Hovering or click on results in the super tab does not do this. It would be better if the grid and tab behaved in a similar manner.

Hover could perhaps also be clicking instead.

@klassenjs
Copy link
Member

I think this is up to how the admin configures the layer in the mapbook. (Not that the demo couldn't be configured better.)

In the demo the results tab feels kind of redundant to the grid as currently configured.

@elil
Copy link
Member Author

elil commented Jun 7, 2017

Yes, let's configure the demo well to get people off to a good start.

I'd like the results and grid to match and be synchronized. Click/Hover/Select in either the results or grid and both it and the other gets highlighted in red. The feature on the map is already nicely doing this (only from grid).

Another approach could be that when grid is maximized, the results tab only shows the highlighted result.

#124 might help this some too.

@theduckylittle
Copy link
Member

@elil - I've done some improvements. Good enough for 3.0.0? Got any more suggestions?

@elil
Copy link
Member Author

elil commented Jun 29, 2017 via email

@chughes-lincoln
Copy link
Contributor

I was able to add the ability to highlight tab results while hovering over them. All you need to do is modify the relevant section in the search template with the highlight section of the parcel-row.html
See where I've made the modifications followed by the entire modified template: https://github.com/geomoose/gm3/blob/master/examples/desktop/mapbook.xml#L74

<template name="search"><![CDATA[ <div class="search-result" onmouseenter="app.highlightFeatures({'PIN' : '{{ properties.PIN }}'}, true)" onmouseleave="app.clearHighlight()" > <div class="search-label"> {{ properties.OWNER_NAME }} </div> <div class="search-action"> <div style="padding: 2px"> <a onClick="app.zoomToExtent([{{ properties.boundedBy | join }}])" class="zoomto-link"> <i class="fa fa-search"></i> {{ properties.PIN }} </a> </div> </div> <div class="search-address"> {{ properties.OWN_ADD_L1 }}<br/> {{ properties.OWN_ADD_L3 }}<br/> </div> </div> ]]></template>

@klassenjs klassenjs added this to the 3.3.1 milestone Apr 27, 2019
@theduckylittle
Copy link
Member

Moving the goal post here to 3.4.0 to discuss if we want to add the above code into the template or write up a doc.

@theduckylittle theduckylittle modified the milestones: 3.3.1, 3.4.0 May 17, 2019
@tchaddad
Copy link
Collaborator

Sounds like this one is ready / could be considered for the current push?

@theduckylittle theduckylittle modified the milestones: 3.4.0, 3.5.0 Jan 5, 2020
@chughes-lincoln
Copy link
Contributor

I think either adding it to the template or adding a doc would be sufficient. I'd lean toward adding it into the template as I don't see much of a con about being able to highlight the tab results. I've also added a line in between results to make it easier to differentiate between results

theduckylittle added a commit to theduckylittle/gm3 that referenced this issue Jan 26, 2020
@theduckylittle
Copy link
Member

PR'd, I believe I caught the changes appropriately.

@elil elil closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants