-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid results and tab results behave differently #95
Comments
I think this is up to how the admin configures the layer in the mapbook. (Not that the demo couldn't be configured better.) In the demo the results tab feels kind of redundant to the grid as currently configured. |
Yes, let's configure the demo well to get people off to a good start. I'd like the results and grid to match and be synchronized. Click/Hover/Select in either the results or grid and both it and the other gets highlighted in red. The feature on the map is already nicely doing this (only from grid). Another approach could be that when grid is maximized, the results tab only shows the highlighted result. #124 might help this some too. |
@elil - I've done some improvements. Good enough for 3.0.0? Got any more suggestions? |
I like the summary information!
Is there a scenario in which the layers will be a number other than 1 (for
select)? (I see Identify which does multiple layers uses the same thing and
makes sense).
This could work for 3.0.0. I'd like to see the tab have identify-like
template information for the individually selected/highlighted grid row.
That way the white space does something productive. It might just be me
favoring the familiar too...
…On Wed, Jun 28, 2017 at 8:57 PM, theduckylittle ***@***.***> wrote:
@elil <https://github.com/elil> - I've done some improvements. Good
enough for 3.0.0? Got any more suggestions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#95 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFBPmqrTGjl3R2NJp8a2rNHlPu9D5POvks5sIyDGgaJpZM4No5La>
.
|
I was able to add the ability to highlight tab results while hovering over them. All you need to do is modify the relevant section in the search template with the highlight section of the parcel-row.html
|
Moving the goal post here to 3.4.0 to discuss if we want to add the above code into the template or write up a doc. |
Sounds like this one is ready / could be considered for the current push? |
I think either adding it to the template or adding a doc would be sufficient. I'd lean toward adding it into the template as I don't see much of a con about being able to highlight the tab results. I've also added a line in between results to make it easier to differentiate between results |
PR'd, I believe I caught the changes appropriately. |
Hovering over grid results highlights that particular parcel in the selection. Hovering or click on results in the super tab does not do this. It would be better if the grid and tab behaved in a similar manner.
Hover could perhaps also be clicking instead.
The text was updated successfully, but these errors were encountered: