When getting locale message, default locale to LocaleContextHolder when locale is null #7516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting locale message, default locale to LocaleContextHolder when locale is null
It was noticed that if we did something like the following when calling an api.
throw new WebApplicationException().withMessageKey("message.key"));
The API Error would contain the message based on the key as follow
"message.key"
The reason for this is because no locale was identified in the exception. If we do the following
throw new WebApplicationException().withMessageKey("message.key").withLocale(LocaleContextHolder.getLocale());
Then the API Error would contain the message on the key as follow
"Some Text for locale"
Since it is better to show text to the end users instead of showing the message key, this PR will default the message key to LocaleContextHolder.getLocale() automatically so that we don't need to supply it for each exception raised.
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation