Skip to content

Conversation

darribas
Copy link
Collaborator

@darribas darribas commented Aug 5, 2018

This PR addresses #25 by adding add_attribution to the plotting module. By default, all plotting functionality will add an attribution statement equal to:

("Map tiles by Stamen Design, under CC BY 3.0. "\
  "Data by OpenStreetMap, under ODbL.")

but can be changed anywhere in the plotting methods across the library.

@darribas darribas requested a review from ljwolf August 5, 2018 21:52
@darribas
Copy link
Collaborator Author

darribas commented Aug 5, 2018

@ljwolf if this looks good and passess tests (pending on #42), I'll cut a release candidate this week so it's pip installable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.86% when pulling 5e9709f on add#25 into 8e5039b on master.

@darribas
Copy link
Collaborator Author

Merging to push new release in time for semester

ax.text(minX + (maxX - minX) * 0.005,
minY + (maxY - minY) * 0.005,
att, size=8,
path_effects=[patheffects.withStroke(linewidth=2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat trick! this is v. useful for annotating plots. had no idea it was in mpl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants