Define Geometry Intersection trait and implement it for Geometry #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdroenner
reviewed
Jul 9, 2020
src/vector/geometry.rs
Outdated
| @@ -43,7 +43,7 @@ impl Geometry { | |||
| *(self.c_geometry_ref.borrow_mut()) = Some(c_geometry); | |||
| } | |||
|
|
|||
| unsafe fn with_c_geometry(c_geom: OGRGeometryH, owned: bool) -> Geometry { | |||
| pub unsafe fn with_c_geometry(c_geom: OGRGeometryH, owned: bool) -> Geometry { | |||
There was a problem hiding this comment.
I'm not sure if we want to pub this method. Could you change it to pub(crate) ?
michaelkirk
reviewed
Jul 10, 2020
| /// otherwise the result might be wrong. | ||
| /// | ||
| /// # Returns | ||
| /// Ok(Geometry) if the two geometries intersect |
There was a problem hiding this comment.
method returns an Option<Geometry>, but this documentation shows as if it returns a Result<Geometry>
There was a problem hiding this comment.
Updated. And added another unit test.
This adds the trait Intersection and implements it for Geometry.
michaelkirk
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built off of #75 since it is already approved.
gdal-sys has vector methods for both layers and geometries. It would be nice if these operations could use one trait, but unfortunately the intersection function signature for layers and geometries is much different.
Seeking comments on the location for these traits. I went with
crate::vector::ops::geometry::intersection.