Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "SpeciesConcMND_?ADV?" diagnostic to output species concentrations in molec cm-3 #1264

Closed

Conversation

jimmielin
Copy link
Contributor

Hi GCST, this is the PR for the commit mentioned in #1022. It may be necessary to rename this to SpeciesMND_ along with renaming SpeciesConc_ to SpeciesVMR_, as suggested by @msulprizio.

Thanks!

Best,
Haipeng

@yantosca
Copy link
Contributor

Thanks @jimmielin. I think this might have to go into 14.1.0, as we are prepping a 14.0.0 release candidate for IGC10.

@msulprizio
Copy link
Contributor

I have merged these updates from @jimmielin into the feature/speciesconcmnd branch in this repository and brought up to date with the latest dev (14.0.0-rc.0). I also made modifications to rename SpeciesConc_ to SpeciesConcVV_ to avoid confusion with SpeciesConcMND implemented here. The HISTORY.rc files have also been updated. These updates are now passing all integration tests, but modifications to GCPy are still needed in order to recognize the change in variable names (I am currently working on this).

@msulprizio msulprizio self-assigned this Jul 7, 2022
@jimmielin
Copy link
Contributor Author

Hi @msulprizio, may I ask about the status of this update? I'm preparing the auto-reduction solver as a pull request hopefully for 14.1.0, and it would be useful to have this update in dev soon as well so it is easier to validate that the solver behaves as intended. Thanks!

Haipeng

Copy link
Contributor

yantosca commented Oct 3, 2022

Thanks for writing @jimmielin. We are going to put this into 14.1.0, as it will require several updates to the benchmarking scripts in GCPy (and we didn't want to have that delay the 14.0.0 release).

@msulprizio msulprizio changed the base branch from dev to main October 18, 2022 16:54
@lizziel lizziel added this to the 14.1.0 milestone Oct 18, 2022
@yantosca
Copy link
Contributor

GCHP integration tests all passed

==============================================================================
GCHP: Execution Test Results

Number of execution tests: 3
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
 
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed:        3
Execution tests failed:        0
Execution tests not completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests passed

==============================================================================
GEOS-Chem Classic: Execution Test Results

Using 24 OpenMP threads
Number of execution tests: 48
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gc_025x03125_CH4_geosfp_47L_na...................Execute Simulation.....PASS
gc_025x03125_fullchem_geosfp_47L_na..............Execute Simulation.....PASS
gc_05x0625_CH4_merra2_47L_na.....................Execute Simulation.....PASS
gc_05x0625_fullchem_merra2_47L_na................Execute Simulation.....PASS
gc_2x25_aerosol_merra2...........................Execute Simulation.....PASS
gc_2x25_CH4_merra2...............................Execute Simulation.....PASS
gc_2x25_CO2_merra2...............................Execute Simulation.....PASS
gc_2x25_fullchem_merra2..........................Execute Simulation.....PASS
gc_2x25_Hg_merra2................................Execute Simulation.....PASS
gc_2x25_metals_merra2............................Execute Simulation.....PASS
gc_2x25_POPs_BaP_merra2..........................Execute Simulation.....PASS
gc_2x25_tagCH4_merra2............................Execute Simulation.....PASS
gc_2x25_tagCO_merra2.............................Execute Simulation.....PASS
gc_2x25_tagO3_merra2.............................Execute Simulation.....PASS
gc_2x25_TransportTracers_merra2..................Execute Simulation.....PASS
gc_2x25_TransportTracers_merra2_LuoWd............Execute Simulation.....PASS
gc_4x5_aerosol_geosfp............................Execute Simulation.....PASS
gc_4x5_aerosol_merra2............................Execute Simulation.....PASS
gc_4x5_CH4_geosfp................................Execute Simulation.....PASS
gc_4x5_CH4_merra2................................Execute Simulation.....PASS
gc_4x5_fullchem_aciduptake_merra2................Execute Simulation.....PASS
gc_4x5_fullchem_APM_merra2.......................Execute Simulation.....PASS
gc_4x5_fullchem_benchmark_merra2.................Execute Simulation.....PASS
gc_4x5_fullchem_complexSOA_merra2................Execute Simulation.....PASS
gc_4x5_fullchem_complexSOA_SVPOA_merra2..........Execute Simulation.....PASS
gc_4x5_fullchem_geosfp...........................Execute Simulation.....PASS
gc_4x5_fullchem_marinePOA_merra2.................Execute Simulation.....PASS
gc_4x5_fullchem_merra2...........................Execute Simulation.....PASS
gc_4x5_fullchem_merra2_47L.......................Execute Simulation.....PASS
gc_4x5_fullchem_merra2_LuoWd.....................Execute Simulation.....PASS
gc_4x5_fullchem_RRTMG_merra2.....................Execute Simulation.....PASS
gc_4x5_fullchem_TOMAS15_merra2_47L...............Execute Simulation.....PASS
gc_4x5_fullchem_TOMAS40_merra2_47L...............Execute Simulation.....PASS
gc_4x5_Hg_geosfp.................................Execute Simulation.....PASS
gc_4x5_Hg_merra2.................................Execute Simulation.....PASS
gc_4x5_metals_merra2.............................Execute Simulation.....PASS
gc_4x5_POPs_BaP_geosfp...........................Execute Simulation.....PASS
gc_4x5_POPs_BaP_merra2...........................Execute Simulation.....PASS
gc_4x5_tagCH4_geosfp.............................Execute Simulation.....PASS
gc_4x5_tagCH4_merra2.............................Execute Simulation.....PASS
gc_4x5_tagCO_geosfp..............................Execute Simulation.....PASS
gc_4x5_tagCO_merra2..............................Execute Simulation.....PASS
gc_4x5_tagO3_geosfp..............................Execute Simulation.....PASS
gc_4x5_tagO3_merra2..............................Execute Simulation.....PASS
gc_4x5_TransportTracers_geosfp...................Execute Simulation.....PASS
gc_4x5_TransportTracers_geosfp_LuoWd.............Execute Simulation.....PASS
gc_4x5_TransportTracers_merra2...................Execute Simulation.....PASS
gc_4x5_TransportTracers_merra2_LuoWd.............Execute Simulation.....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 48
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

yantosca added a commit that referenced this pull request Oct 24, 2022
…hem into feature/autoreduce_14.1

This merge brings in @jimmielin's adaptive solver capability using
KPP 3.0.0 into the 14.1.0 development branch.

NOTE: This should be merged after  geoschem/geos-chem PR #1264
(the SpeciesConc_MND diagnostic collection update).

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@msulprizio msulprizio changed the base branch from main to dev/14.1.0 November 2, 2022 16:41
@msulprizio
Copy link
Contributor

This PR is now superseded by #1572, which also includes renaming the SpeciesConc variable to SpeciesConcVV.

@msulprizio msulprizio closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Diagnostics Related to output diagnostic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants