Update version from v1.0-beta.4 to v1.0.4 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/wjiang/add_load_interface Fixes Goddard-Fortran-Ecosystem#42: add parser load interface to load a file
This PR makes/adds an `NVHPC.cmake` file identical to that used in pFUnit
Basically all the compilers used under development can break doing deep copies of a nested data structure using default assignment. The workaround has been to instead add nested nodes (sequence or mapping) by first adding an empty node and then copying the elements recursively. The strategy has not been propagated everywhere, but should mostly be there. With a bit of cleanup it should be easy to add where needed when more issues are encountered.
…Ecosystem/feature/mathomp4/nvhpc-support Add NVHPC Support
…Ecosystem/feature/Goddard-Fortran-Ecosystem#46-setters Feature/Goddard-Fortran-Ecosystem#46 setters
Apparently gFortran does not like multiple polymorphic allocations of the same object in a procedure. Rather than explicit deallocates, have rearranged code so that assignment happens only once.
Still has issues with nested sequences.
Problem was apparently a non-recursive FINAL provided by the compiler.
Updated examples/tests.
And associated examples.
newParser => Parser AbstractNode => YAML_Node
11.1 is broken on ubuntu
…Ecosystem/hotfix/cmake-syntax-error Fix for cmake syntax error.
(Better) workaround for GFortran recursion problem. - A wrapper type proved sufficient where a global stack was used before. Symptom was incorrect values in local variables after coming back up from recursion chain. - Also removed other workarounds that no longer seem necessary.
- reliably passing tests on - GFortran 11.2 - Intel 2022.1.0 - NAG 7.0_7066 (7.1 series is broken wrt gFTL at this time)
…Ecosystem/feature/fixes-and-compiler-workarounds Feature/fixes and compiler workarounds
This reduces the number of SELECT TYPE blocks in the Parser logic.
…Ecosystem/feature/mathomp4/update-ci-yafyaml Update GitHub Actions
…Ecosystem/hotfix/compiler-workaround Hotfix/compiler workaround
…Ecosystem/hotfix/cmake-logic Fixed CMake logic.
…Ecosystem/feature/mathomp4/fix-string-tests-bmauer-remove-stops Fixes for string equality tests for gcc
…Ecosystem/feature/bmauer/remove-stops Remove stops, another step to more robust error handling
# Conflicts: # CMakeLists.txt Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of a group of pull requests to update MAPL from 2.18.3 to 2.26.0 in GCHP. See instructions here: geoschem/GCHP#265
This pull request updates the yaFyaml version from v1.0-beta.4 to v1.0.4. It is required for compatibility with MAPL 2.26.0 (geoschem/MAPL#23).