Skip to content

Conversation

jericks
Copy link
Member

@jericks jericks commented Nov 8, 2014

Hi Justin!

This pull request adds a few linear referencing methods to the line string geometry class.

Thanks!
Jared

@jdeolive
Copy link
Contributor

Looks good Jared. One thing I might change is to allow the methods to accept all the forms of a point that the Point class constructor takes. Should be easily able to do that just by invoking the Point constructor as the first thing in the methods.

@jericks
Copy link
Member Author

jericks commented Nov 18, 2014

Hi Justin! Does this look good? I modified it so you can pass in a Point or a variable list of coordinates:

point = line.placePoint(Point(1153461.34, 649950.30))
or
point = line.placePoint(1153461.34, 649950.30)

Thanks,
Jared

@jdeolive
Copy link
Contributor

Looks great!

@jericks
Copy link
Member Author

jericks commented Dec 9, 2014

Hi Justin!

Is this ok to merge?

Thanks,
Jared

jdeolive pushed a commit that referenced this pull request Dec 9, 2014
Add linear referencing methods to linestring
@jdeolive jdeolive merged commit b805462 into geoscript:master Dec 9, 2014
@jdeolive
Copy link
Contributor

jdeolive commented Dec 9, 2014

Oops, sorry Jared. Definitely good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants