For more information the issue is here: http://jira.codehaus.org/browse/GEOS-5398
This pull request tracks the FeatureCollection cleanup proposal, removing deprecated methods from FeatureCollection.
Updates for GeoTools FeatureCollection api changes
There is a DataUtilities.close( iterator ) that aaime requested, it does allow you to avoid null checks
I have been doing the try / finally thing to ensure iterator is closed
This looks fine, if the security feature collection wrapper does not provide the add / addAll methods then the delegate is safe from unauthorised alteration
Looks like the comments showed up above - summary:
Looks like the comments showed up - summary:
Rebasing this branch locally and trying it out now that the FC geotools pull request is live.