Skip to content

Updates for GeoTools FeatureCollection api changes (GEOS-5398) #61

Closed
wants to merge 1 commit into from

2 participants

@jdeolive

For more information the issue is here: http://jira.codehaus.org/browse/GEOS-5398

This pull request tracks the FeatureCollection cleanup proposal, removing deprecated methods from FeatureCollection.

@jodygarnett

There is a DataUtilities.close( iterator ) that aaime requested, it does allow you to avoid null checks

@jodygarnett

I have been doing the try / finally thing to ensure iterator is closed

@jodygarnett

This looks fine, if the security feature collection wrapper does not provide the add / addAll methods then the delegate is safe from unauthorised alteration

@jodygarnett
GeoServer member

Looks like the comments showed up above - summary:

@jodygarnett
GeoServer member

Looks like the comments showed up - summary:

  1. The changes were smoothly applied, did not see any major workarounds like in GeoTools or uDig 2 We could make use of some of those DataUtilities methods.
  2. I tend to do try / finally around each FeatureIterator
  3. The security feature collections were fine, I wanted to make sure there was no way to accidentally get to the delegate and "add" anything. And yes they are all wrapped up
@jodygarnett
GeoServer member

Rebasing this branch locally and trying it out now that the FC geotools pull request is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.