Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for GeoTools FeatureCollection api changes (GEOS-5398) #61

Closed
wants to merge 1 commit into from

Conversation

jdeolive
Copy link
Contributor

For more information the issue is here: http://jira.codehaus.org/browse/GEOS-5398

This pull request tracks the FeatureCollection cleanup proposal, removing deprecated methods from FeatureCollection.

@jodygarnett
Copy link
Member

Looks like the comments showed up above - summary:

@jodygarnett
Copy link
Member

Looks like the comments showed up - summary:

  1. The changes were smoothly applied, did not see any major workarounds like in GeoTools or uDig
    2 We could make use of some of those DataUtilities methods.
  2. I tend to do try / finally around each FeatureIterator
  3. The security feature collections were fine, I wanted to make sure there was no way to accidentally get to the delegate and "add" anything. And yes they are all wrapped up

@jodygarnett
Copy link
Member

Rebasing this branch locally and trying it out now that the FC geotools pull request is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants