Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map plugin should not initizialize invalid maps #10448

Closed
1 task done
allyoucanmap opened this issue Jul 2, 2024 · 0 comments · Fixed by #10449 or #10650
Closed
1 task done

Map plugin should not initizialize invalid maps #10448

allyoucanmap opened this issue Jul 2, 2024 · 0 comments · Fixed by #10449 or #10650

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Jul 2, 2024

Description

The Map plugin initializes all map configurations that are truthy and this includes also configuration like this one:

{
    "eventListeners": {
        "click": []
    },
    "mousePointer": "pointer"
}

For example the eventListeners property is persisted when we reset a map configuration.
It would be better to improve the if statement in the Map.jsx plugin to ensure only valid map configurations are initializing the component.
We could also remove the canRender state not used anymore

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information

@allyoucanmap allyoucanmap self-assigned this Jul 2, 2024
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Jul 2, 2024
@allyoucanmap allyoucanmap linked a pull request Jul 2, 2024 that will close this issue
5 tasks
@tdipisa tdipisa added this to the 2024.02.01 milestone Sep 18, 2024
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 4, 2024
@ElenaGallo ElenaGallo self-assigned this Oct 23, 2024
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Nov 5, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment