Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined query should match all items #73

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

lukashass
Copy link
Member

@lukashass lukashass commented Jun 15, 2022

This mimics feathers behavior.

Apparently sift handles an undefined query differently.

@lukashass lukashass requested a review from anbraten June 15, 2022 18:55
@github-actions
Copy link

github-actions bot commented Jun 15, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 100% 133/133
🟢 Branches 100% 30/30
🟢 Functions 100% 30/30
🟢 Lines 100% 194/194

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 05e9876

@lukashass lukashass merged commit df1dcb0 into main Jun 15, 2022
@lukashass lukashass deleted the fix-event-handler-when-query-undefined branch June 15, 2022 20:28
@github-actions
Copy link

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants