Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail HTLC backwards in all scenarios when handling HTLCIntercepted event #943

Closed
luckysori opened this issue Jul 13, 2023 · 2 comments · Fixed by #979
Closed

Fail HTLC backwards in all scenarios when handling HTLCIntercepted event #943

luckysori opened this issue Jul 13, 2023 · 2 comments · Fixed by #979
Assignees
@luckysori
Labels
bug Something isn't working

Comments

@luckysori
Copy link
Contributor

We should consider handling all errors in a single spot so that we can consistently fail the HTLC backwards.

We have recently run into not failing the HTLC backwards in production, which leads to users having to wait a long time for their funds to return to their funding wallets.
@luckysori luckysori added the bug Something isn't working label Jul 13, 2023
@luckysori luckysori self-assigned this Jul 13, 2023
@bonomat
Copy link
Contributor

bonomat commented Jul 13, 2023

Thanks for reporting. This could also be the reason for a recent force-closure: one of our channels was closed because of a "stuck" htlc according to the other party.

@luckysori
Copy link
Contributor Author

I would like to tackle this soon (in this iteration) once #950 is merged.

@luckysori luckysori mentioned this issue Jul 22, 2023
Merged
@bonomat bonomat mentioned this issue Jul 24, 2023
Closed
bors bot added a commit that referenced this issue Jul 25, 2023
@bors @luckysori
Merge #979
290884c 
979: Fail intercepted HTLC backwards when we should r=luckysori a=luckysori

Fixes #943.
Fixes #944.

---

This is yet another instance where we have to consider the fact that the same event handler code runs for both app and coordinator even though certain parts need to be specific to each role. I've increased the implicit annoyance counter of #885.

Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
@bors bors bot closed this as completed in 0a9c34d Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luckysori luckysori

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail intercepted HTLC backwards when we should get10101/10101
2 participants
@bonomat @luckysori