Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cache #2068

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Simplify cache #2068

merged 1 commit into from
Feb 21, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Feb 20, 2024

Using default cache settings will stop us from caching cargo binaries. This might slow down our production build but hopefully gets rid of random errors where libraries were already installed.

luckysori
luckysori approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-binstall might be interesting here.

@bonomat bonomat added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 910ef35 Feb 21, 2024
19 of 21 checks passed
@bonomat bonomat deleted the fix/cache-os-specific branch February 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckysori luckysori luckysori approved these changes

@holzeis holzeis Awaiting requested review from holzeis

Assignees

@bonomat bonomat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonomat @luckysori