Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate transaction entry in keysend payments #385

Merged
merged 7 commits into from
Aug 2, 2024
Merged

fix: duplicate transaction entry in keysend payments #385

merged 7 commits into from
Aug 2, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Aug 1, 2024 •
edited
Loading

Fixes #360

  • Update LDK dependency
  • Fix tests

Also returns fees_paid in pay_keysend and multi_pay_keysend responses, and improves some keysend tests

Note: Greenlight and Breez keysend support has been temporarily removed.

Tests:

  • Pay keysend (LDK)
  • Pay keysend (LND Polar)

Duplicate transactions no longer show.

@rolznz rolznz mentioned this pull request Aug 1, 2024
Closed
@rolznz rolznz requested review from bumi and im-adithya August 2, 2024 08:42
@rolznz rolznz marked this pull request as ready for review August 2, 2024 08:42
@rolznz rolznz added this to the v1.4.1 milestone Aug 2, 2024
@rolznz rolznz merged commit c79e11e into master Aug 2, 2024
8 checks passed
@rolznz rolznz deleted the fix/keysend-duplicate-transaction-entry-v2 branch August 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumi bumi Awaiting requested review from bumi

@im-adithya im-adithya Awaiting requested review from im-adithya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

Bug: duplicate keysend payment entries in transactions table
1 participant
@rolznz