feat: add NWC client method to get wallet service supported methods #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
commented
Feb 22, 2024
bumi
approved these changes
Feb 22, 2024
src/NWCClient.ts
Outdated
| @@ -181,6 +181,35 @@ export class NWCClient { | |||
| return new NWCClient(options); | |||
| } | |||
|
|
|||
| static async getWalletServiceSupportedMethods( | |||
There was a problem hiding this comment.
how about making on the instance? why do you think it should be on the class level?
client = NWCClient.withNewSecret(options);
await client.supportedMethods();
There was a problem hiding this comment.
That makes sense. Sorry, I originally thought we could request the methods just using the relay URL, but then they can't be filtered by the wallet service pubkey (just in case).
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/nostr-protocol/nips/blob/master/47.md#theory-of-operation to get "info" (actually just supported methods) from the relay