Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add payment_sent notification #223

Merged
merged 3 commits into from
Jun 24, 2024
Merged

feat: add payment_sent notification #223

merged 3 commits into from
Jun 24, 2024

Conversation

im-adithya
Copy link
Member

Adds payment_sent support in NIP47 Notifications

@bumi
Copy link
Contributor

bumi commented Jun 13, 2024

@rolznz what do you think? should we provide the option here on a client level to either subscribe to incoming or outgoing ones? (and just drop the other ones)

@rolznz
Copy link
Contributor

rolznz commented Jun 14, 2024

@bumi hmm, this is good we decided to implement this now. I guess returning extra notification types could possibly break some clients if they do not specifically check the notification type in their code, and it's also wasteful if they get notifications they don't need.

I wonder if we should add a tag of the notification type. Then clients can use the filter they need in the standard nostr way.

@rolznz
Copy link
Contributor

rolznz commented Jun 17, 2024

I wonder if we should add a tag of the notification type. Then clients can use the filter they need in the standard nostr way.

We probably shouldn't do this - the tag will expose extra metadata, so maybe just enable on the client side instead.

Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@im-adithya im-adithya changed the title chore: add payment_sent notification freat: add payment_sent notification Jun 24, 2024
@im-adithya im-adithya changed the title freat: add payment_sent notification feat: add payment_sent notification Jun 24, 2024
@im-adithya im-adithya merged commit d2ace2a into master Jun 24, 2024
3 checks passed
@pavanjoshi914 pavanjoshi914 deleted the task-sent-notif branch July 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants