fix: pass TLV value as hex from nwc webln provider to nwc client keysend #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@im-adithya good catch, thanks! |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/css-tree@1.1.3, npm/domhandler@4.3.1, npm/is-callable@1.2.7, npm/is-string@1.0.7, npm/is-symbol@1.0.4, npm/regexp.prototype.flags@1.4.3 |
im-adithya
reviewed
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With WebLN keysend TLVs, the value is passed as plaintext:
https://www.webln.guide/building-lightning-apps/webln-reference/webln.keysend
In NIP-47 spec the value should be hex encoded:
https://github.com/nostr-protocol/nips/blob/master/47.md#pay_keysend
This PR fixes the NostrWeblnProvider to pass the TLV values hex-encoded instead of plaintext.