token changed callback #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanjoshi914
force-pushed
the
token-change-callback
branch
from
1af2062
to
eea29e1
Compare
rolznz
reviewed
Aug 4, 2023
rolznz
reviewed
Aug 4, 2023
|
@pavanjoshi914 can you please update the README with a section on how to subscribe to token changes? |
event function will return empty promises onwards signed-off-by: pavan joshi <pavanj914@gmail.com>
rolznz
reviewed
Aug 5, 2023
rolznz
reviewed
Aug 5, 2023
shift emitting event in refreshAccessToken itself handle types emit events even when user manually refreshes token signed-off-by: pavan joshi <pavanj914@gmail.com>
bumi
reviewed
Aug 7, 2023
src/OAuth2User.ts
Outdated
| @@ -84,8 +98,11 @@ export class OAuth2User implements OAuthClient { | |||
| const token = processTokenResponse(data); | |||
| this.token = token; | |||
| resolve({token}); | |||
| this._tokenEvents.emit("tokens", this.token); | |||
There was a problem hiding this comment.
should we also add a verb here? (like in tokenRefresh, accountChange, ...)
rolznz
reviewed
Aug 8, 2023
rolznz
reviewed
Aug 8, 2023
rolznz
reviewed
Aug 8, 2023
rolznz
approved these changes
Aug 8, 2023
|
@pavanjoshi914 can you test these changes with the Alby extension using yarn link? using these callbacks should be much cleaner than the current solution. |
rolznz
reviewed
Aug 14, 2023
rolznz
reviewed
Aug 14, 2023
change event name to tokenRefreshed signed-off-by: pavan joshi <pavanj914@gmail.com>
|
good for me. @rolznz feel free to merge it. |
rolznz
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31