Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] I shouldn't be able to edit fields like description after I click on Create invoice button #1659

Closed
bitcoinuser opened this issue Oct 24, 2022 · 2 comments · Fixed by #1668
Closed

[BUG] I shouldn't be able to edit fields like description after I click on Create invoice button #1659

bitcoinuser opened this issue Oct 24, 2022 · 2 comments · Fixed by #1668
Assignees
@vaibhavgarg237
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@bitcoinuser
Copy link
Contributor

bitcoinuser commented Oct 24, 2022 •
edited by escapedcat
Loading

Describe the bug

I'm able to edit fields like description after I click on Create invoice button. I reproduced the problem when I experienced a slow time to generate the invoice.
It's the same bug resolved by this: #1572

Steps To Reproduce

  1. Go to receive, and click on create invoice button
  2. to write something on description field

Obs. To reproduce, the generate invoice needs to be slow. This sometimes happens.

Expected behavior

The field description should be disabled after click on Create Invoice button

Alby information

Alby version: 1.18
@escapedcat
Copy link
Contributor

As suggested we should use the same approach as in "Send" using a fieldset to disable inputs.

@escapedcat escapedcat added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 24, 2022
vaibhavgarg237 added a commit to vaibhavgarg237/lightning-browser-extension that referenced this issue Oct 25, 2022
@vaibhavgarg237
fix: disable input fields on Create Invoice getAlby#1659
372bc19
@vaibhavgarg237 vaibhavgarg237 mentioned this issue Oct 25, 2022
Merged
3 tasks
@vaibhavgarg237
Copy link
Contributor

I have opened PR for this issue #1668 just like #1572

vaibhavgarg237 added a commit to vaibhavgarg237/lightning-browser-extension that referenced this issue Oct 27, 2022
@vaibhavgarg237
fix: disable input fields on Create Invoice getAlby#1659
d7614d1
bumi pushed a commit that referenced this issue Oct 27, 2022
@vaibhavgarg237
fix: disable input fields on Create Invoice #1659 (#1668)
e109aa6
bumi added a commit that referenced this issue Nov 1, 2022
@bumi
Merge branch 'feature/generic-webln-request' into feature/commando-co…
0e892a0 
…nnector

# By Lisa Oppermann (15) and others
# Via GitHub (22) and others
* feature/generic-webln-request: (58 commits)
  feat: add generic request method to webln
  fix: publisher link on AllowanceView
  Translated using Weblate (Italian)
  Update all development Yarn dependencies (2022-10-29)
  fix: align reject/close function params
  fix: navigate on send
  Update dayjs to version 1.11.6
  fix: disable input fields on Create Invoice #1659 (#1668)
  Update react-i18next to version 12.0.0
  Push buttons to bottom in Send and Receive Screens (#1672)
  refactor(lnurl): getDetails - avoid typecasting (#1545)
  style: prettier
  Translated using Weblate (Italian)
  Update tailwindcss to version 3.2.1
  style: prettier
  Translated using Weblate (Portuguese (Brazil))
  style: prettier
  Translated using Weblate (Italian)
  Translated using Weblate (Swedish)
  fix: remove response and additional error message
  ...

# Conflicts:
#	yarn.lock
bumi added a commit that referenced this issue Nov 1, 2022
@bumi
Merge branch 'master' into feature/commando-connector
3651846 
# By Lisa Oppermann (15) and others
# Via GitHub (22) and others
* master: (57 commits)
  fix: publisher link on AllowanceView
  Translated using Weblate (Italian)
  Update all development Yarn dependencies (2022-10-29)
  fix: align reject/close function params
  fix: navigate on send
  Update dayjs to version 1.11.6
  fix: disable input fields on Create Invoice #1659 (#1668)
  Update react-i18next to version 12.0.0
  Push buttons to bottom in Send and Receive Screens (#1672)
  refactor(lnurl): getDetails - avoid typecasting (#1545)
  style: prettier
  Translated using Weblate (Italian)
  Update tailwindcss to version 3.2.1
  style: prettier
  Translated using Weblate (Portuguese (Brazil))
  style: prettier
  Translated using Weblate (Italian)
  Translated using Weblate (Swedish)
  fix: remove response and additional error message
  fix: use math floor everywhere
  ...

# Conflicts:
#	yarn.lock
bumi added a commit that referenced this issue Nov 5, 2022
@bumi
Merge branch 'master' into feature/lnc-web
9cb1122 
# By Lisa Oppermann (15) and others
# Via GitHub (35) and escapedcat (1)
* master: (75 commits)
  fix: remove runcitadel sdk dependency (#1681)
  chore(deps): update puppeteer to v19
  revert(deps): puppeteer and fake-indexdb
  Update fake-indexeddb to version 4.0.0
  Update @types/chrome to version 0.0.200
  Update puppeteer to version 19.2.0
  fix: publisher link on AllowanceView
  Translated using Weblate (Italian)
  Update all development Yarn dependencies (2022-10-29)
  chore: remove showcases
  chore: remove topup app
  fix: align reject/close function params
  fix: navigate on send
  Update dayjs to version 1.11.6
  fix: disable input fields on Create Invoice #1659 (#1668)
  Update react-i18next to version 12.0.0
  Push buttons to bottom in Send and Receive Screens (#1672)
  refactor(lnurl): getDetails - avoid typecasting (#1545)
  style: prettier
  Translated using Weblate (Italian)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaibhavgarg237 vaibhavgarg237

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable input fields on Create Invoice #1659 vaibhavgarg237/lightning-browser-extension
3 participants
@escapedcat @bitcoinuser @vaibhavgarg237