-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preimage in transaction table #2107
Conversation
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
@im-adithya What is up with these E2E tests? Some sort of server issue? |
Yeah, no worries. This happens every now and then. |
Bit of context:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack
Yeah user can just double click and copy now. |
Thanks for this PR! I also think that we don't need the copy button for now. 👍 Would it maybe make sense to display the preimage at the very end though? I think the fees are more relevant to users than the preimage. |
Yeah would do! |
@reneaaron Done. |
Great, thank you very much for the quick update! 💪 |
Describe the changes you have made in this PR
The preimage is now showing in transaction table as somehow it had previously been removed. I have added a check to see if there is indeed a preimage present or not.
Link this PR to an issue [optional]
Fixes #2105
Type of change
fix
: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes [optional]
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist