Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preimage in transaction table #2107

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

manavdesai27
Copy link
Contributor

Describe the changes you have made in this PR

The preimage is now showing in transaction table as somehow it had previously been removed. I have added a check to see if there is indeed a preimage present or not.

Link this PR to an issue [optional]

Fixes #2105

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Screenshot from 2023-02-14 11-59-59

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented Feb 14, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@manavdesai27
Copy link
Contributor Author

@im-adithya What is up with these E2E tests? Some sort of server issue?

@escapedcat
Copy link
Contributor

@im-adithya What is up with these E2E tests? Some sort of server issue?

Yeah, no worries. This happens every now and then.

@escapedcat
Copy link
Contributor

Bit of context:

Copy link
Contributor

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@manavdesai27
Copy link
Contributor Author

Do we still want this? I don't think it's needed. With this PR a user can just double-click the text and copy it, right?

Yeah user can just double click and copy now.

@reneaaron
Copy link
Contributor

Thanks for this PR! I also think that we don't need the copy button for now. 👍

Would it maybe make sense to display the preimage at the very end though? I think the fees are more relevant to users than the preimage.

@manavdesai27
Copy link
Contributor Author

Thanks for this PR! I also think that we don't need the copy button for now. +1

Would it maybe make sense to display the preimage at the very end though? I think the fees are more relevant to users than the preimage.

Yeah would do!

@manavdesai27
Copy link
Contributor Author

@reneaaron Done.

@escapedcat escapedcat merged commit ce1b4b0 into getAlby:master Feb 14, 2023
@reneaaron
Copy link
Contributor

Great, thank you very much for the quick update! 💪

@manavdesai27 manavdesai27 deleted the fix/preimage_tx_list branch February 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the preimage in the transaction list
3 participants