feat: avoid overflow for continuous strings in description #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if we don't want to hide continuous strings overflow maybe we just use break-words there |
|
@pavanjoshi914 Yeah, let's just use break-words here. In the npub case you want to see the full npub and it's not good if we just cut the text off and display an ellipsis. |
|
@reneaaron made relevant changes merging this. Tack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
avoid overflow for continuous strings
Link this PR to an issue [optional]
Fixes #3009
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes [optional]
single continuous string:
non continuous strings:
noncontinuous strings having some larger continuous strings:
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist