Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Alby JS SDK to 3.4.0 #3066

Merged
merged 1 commit into from
Mar 6, 2024
Merged

chore: bump Alby JS SDK to 3.4.0 #3066

merged 1 commit into from
Mar 6, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Mar 6, 2024

This fixes error messages not being displayed from errors in the NWC connector due to Alby JS SDK previously not throwing proper error objects (therefore the message field being undefined and the error falling back to "Something went wrong")

image

Copy link
Contributor

@pavanjoshi914 pavanjoshi914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we shall avoid longer error messages. it shall be upto the client to add string like "something went wrong". extension scheme is simple "Error: error.message" where error.message shall indicate actual reason of error directly.

rest tAck

@pavanjoshi914 pavanjoshi914 merged commit 2010eed into master Mar 6, 2024
6 checks passed
@pavanjoshi914 pavanjoshi914 deleted the chore/bump-js-sdk branch March 6, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants