-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI check failed on reporting coverage #492
Labels
Comments
Pinging @mottosso 📞 |
Nice catch, solution 2 sounds good to me as well. At first I thought we were going to have to change the underlying Maya Docker images, that would have been a fair bit more involved. Phew! Will you take care of this @davidlatwe? |
Closed
Done ! |
Someone has reporting this 👉 z4r/python-coveralls#73 |
mottosso
added a commit
that referenced
this issue
Dec 20, 2019
Fix #492: Resolve CI coverage bug by pinning coverage==4.5.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened ?
The module
coverage
updated to version 5.0 yesterday, butpython-coveralls
seems not yet adopted. Which leads to https://travis-ci.org/getavalon/core/builds/625677709#L556coverage
has dropped theReporter
base class sincecoverage-5.0a6
, but the latestpython-coveralls
still importing it here.Solution
In /Dockerfile-maya2016
coverage
version to4.5.4
. ORcoverage
frompip
install list and replacepython-coveralls
withcoveralls
, becausecoveralls
already took care and pinned the version ofcoverage
it needs here.python-coveralls
didn't.I lean to go with solution 2.
The text was updated successfully, but these errors were encountered: