Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI check failed on reporting coverage #492

Closed
davidlatwe opened this issue Dec 16, 2019 · 4 comments · Fixed by #495
Closed

Travis CI check failed on reporting coverage #492

davidlatwe opened this issue Dec 16, 2019 · 4 comments · Fixed by #495
Labels

Comments

@davidlatwe
Copy link
Collaborator

davidlatwe commented Dec 16, 2019

What happened ?

The module coverage updated to version 5.0 yesterday, but python-coveralls seems not yet adopted. Which leads to https://travis-ci.org/getavalon/core/builds/625677709#L556

coverage has dropped the Reporter base class since coverage-5.0a6, but the latest python-coveralls still importing it here.

Solution

In /Dockerfile-maya2016

  1. Pin coverage version to 4.5.4. OR
  2. Remove coverage from pip install list and replace python-coveralls with coveralls, because coveralls already took care and pinned the version of coverage it needs here. python-coveralls didn't.

I lean to go with solution 2.

@davidlatwe
Copy link
Collaborator Author

Pinging @mottosso 📞

@mottosso
Copy link
Contributor

Nice catch, solution 2 sounds good to me as well. At first I thought we were going to have to change the underlying Maya Docker images, that would have been a fair bit more involved. Phew! Will you take care of this @davidlatwe?

@mottosso mottosso added the bug label Dec 16, 2019
@davidlatwe davidlatwe mentioned this issue Dec 16, 2019
@davidlatwe
Copy link
Collaborator Author

Done !

@davidlatwe
Copy link
Collaborator Author

Someone has reporting this 👉 z4r/python-coveralls#73

mottosso added a commit that referenced this issue Dec 20, 2019
Fix #492: Resolve CI coverage bug by pinning coverage==4.5.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants