Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt proper message if no creator plugin been found #490

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Prompt proper message if no creator plugin been found #490

merged 1 commit into from
Dec 20, 2019

Conversation

davidlatwe
Copy link
Collaborator

What happened ?

If no creator plugin been registered, launching creator tool will raise following error

# Traceback (most recent call last):
#   File "...\avalon-core\avalon\tools\creator\app.py", line 302, in _on_data_changed
#     family = plugin.family.rsplit(".", 1)[-1]
# AttributeError: 'NoneType' object has no attribute 'family'

Should prompt a message instead.

What's changed ?

The "no creator plugin" scenario has been handled plus echoing a message on GUI.

BigRoy
BigRoy approved these changes Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davidlatwe davidlatwe merged commit cc0574c into getavalon:master Dec 20, 2019
@davidlatwe davidlatwe deleted the fix-no-creator branch December 23, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlatwe @BigRoy