Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/UX feedback #28

Closed
mishushakov opened this issue Nov 28, 2022 · 14 comments
Closed

UI/UX feedback #28

mishushakov opened this issue Nov 28, 2022 · 14 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1-beta.14

Comments

@mishushakov
Copy link

Screenshot 2022-11-28 at 14 04 07

Screenshot 2022-11-28 at 14 00 08

Screenshot 2022-11-28 at 14 10 43

Screenshot 2022-11-28 at 14 05 52

Screenshot 2022-11-28 at 14 16 53

Screenshot 2022-11-28 at 14 18 40

Happy to answer questions. Will add more stuff if I have some.
Спасибо!
@mishushakov
Copy link
Author

Screenshot 2022-11-28 at 18 52 59

@mishushakov
Copy link
Author

Add border around tabs

Screenshot 2022-11-28 at 18 57 18

Screenshot 2022-11-28 at 18 58 04

@mishushakov
Copy link
Author

What is wrong?

Screenshot 2022-11-28 at 19 00 56

@notmedia notmedia added the good first issue Good for newcomers label Nov 29, 2022
@notmedia notmedia modified the milestones: v1-beta.13, v1-beta.14 Nov 30, 2022
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): uncaught exception on macOS when app was closed and reopened
fc54fb5
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): collection tree search input placeholder
8da81f6
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): select collection placeholder
03f9478
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): reduce vertical space between tree nodes in all lists
dc31a9b
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): open tab by one click
7a1a37b
@notmedia
Copy link
Contributor

notmedia commented Dec 6, 2022 •
edited
Loading

  • Uncaught exception on macOS when app was closed and reopened
  • Placeholder in collection search input
  • "No collections" placeholder in the tree
  • Add pointer cursor to menu item buttons
  • "No tabs" placeholder in tabs container, put more info
  • Action button in collection tree always visible
  • Open tab on single click
  • Reduce vertical space between items in collections tree
  • "Press cmd+k to open menu"
  • Add icon in tab - moved to Informative tabs #38
  • Add tooltip for TLS configuration
  • Add tooltip for save environment
  • Is tls configuration in address input button?
  • Is save environment in address input button?
  • Place badge with response status in response tab near timings
  • Which format in Request/Metadata should I use?
  • Rebuild file inputs in collection form
  • Rebuild Include directories in collection form
  • Toasts appears outside the screen
  • Delete button always visible in TLS configuration
  • Make understandable tooltip why switching to gRPC-Web is disabled
  • Margins in code editors - wontfix
  • Border in tabs - wontfix
  • Collapse button in menu - wontfix right now, I will think about it

notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): menu collapse
85bc152
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): add pointer to menu items
dd3dbef
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): clear select collection on add from another collection click
a288bf8
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): toasts appears outside the screen
f2bcb06
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): add response status badge
adbbac9
notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): rebuild fileinput
9542dc1
@notmedia
Copy link
Contributor

notmedia commented Dec 6, 2022

Hey, about "Toasts appears outside the screen" - I'm using https://fkhadra.github.io/react-toastify/introduction/ for toasts, here I applied option for create newest notifications on top, but this is how working this library

notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): place newest notifications on top
ade02cf
@mishushakov
Copy link
Author

For "Address is empty" you can just outline the input field in red, this is better UX

@notmedia
Copy link
Contributor

notmedia commented Dec 6, 2022

Yeah you totally right! Thank you!

notmedia added a commit that referenced this issue Dec 6, 2022
@notmedia
fix(#28): add pointer cursor to fileinput clear button
8a5671f
notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): add default cursors to fileinput
6ad1ca1
notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): action button in collection menu always visible
e1180d2
notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): delete button always visible in TLS configuration
79b58dd
notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
feat(#28): add welcome page
5abb2c9
notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): update key bindings for shortcuts
4beb0fa
@notmedia
Copy link
Contributor

notmedia commented Dec 7, 2022

I have not added more info in "no collections" section because we already have Shortcuts on welcome screen when app starts

image

notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): save environment tooltip
958348b
notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): enter delay on toolitp
a562540
@notmedia
Copy link
Contributor

notmedia commented Dec 7, 2022

Screenshot 2022-11-28 at 18 52 59

Why adding this margins is better? Im trying to figure it out, this code editors are main workspace for the user, its better if it full screen I think

notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): add unique key for shortcuts on welcome page
77c8b3e
@notmedia
Copy link
Contributor

notmedia commented Dec 7, 2022

Add border around tabs

Screenshot 2022-11-28 at 18 57 18 Screenshot 2022-11-28 at 18 58 04

I tested borders before and got that without them it seems more beautiful

image

Here I implemented tabs like in UI Kit that I'm using did - https://nextui.org/docs/components/button#icons
image

notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): changed url input styles
fb58211
notmedia added a commit that referenced this issue Dec 7, 2022
@notmedia
fix(#28): error color for fileinput label
a799375
@mishushakov
Copy link
Author

mishushakov commented Dec 7, 2022 •
edited
Loading

Screenshot 2022-12-07 at 19 13 10

maybe try something like this on the search bar and when I press on it, the command bar opens? Also the shortcut will always be visible

@mishushakov
Copy link
Author

I have not added more info in "no collections" section because we already have Shortcuts on welcome screen when app starts

Here you can add a placeholder icon and tell why no collections are found. Also make a big button "Add collection"

@notmedia notmedia added the enhancement New feature or request label Dec 7, 2022
notmedia added a commit that referenced this issue Dec 9, 2022
@notmedia
feat(#28): add command bar shortcut to menu
ef2ae34
@notmedia
Copy link
Contributor

notmedia commented Dec 9, 2022

Screenshot 2022-12-07 at 19 13 10

maybe try something like this on the search bar and when I press on it, the command bar opens? Also the shortcut will always be visible

I put this kbd inside the menu:
Screenshot 2022-12-09 at 17 38 39

notmedia added a commit that referenced this issue Dec 9, 2022
@notmedia
fix(#28): add toolbar with JSON text for request/metadata
7764553
notmedia added a commit that referenced this issue Dec 9, 2022
@notmedia
fix(#28): gap for toolbar
e3dd9b9
@notmedia
Copy link
Contributor

notmedia commented Dec 9, 2022

Collapse button in menu - I will think about this, I like VS Code approach they don't have collapse button

notmedia added a commit that referenced this issue Dec 10, 2022
@notmedia
fix(#28): update json font size
0a30b28
notmedia added a commit that referenced this issue Dec 11, 2022
@notmedia
fix(#28): add empty object in request and metadata on new tab
cd2ac46
notmedia added a commit that referenced this issue Dec 12, 2022
@notmedia
fix(#28): make no responsive code editors request/metadata
d233baa
notmedia added a commit that referenced this issue Dec 12, 2022
@notmedia
fix(#28): add maxWidth to environment select
a78f8c6
@notmedia notmedia mentioned this issue Dec 12, 2022
Open
notmedia added a commit that referenced this issue Dec 12, 2022
@notmedia
fix(#28): add invoke request shortcut in empty response view
49ac01b
notmedia added a commit that referenced this issue Dec 12, 2022
@notmedia
fix(#28): add empty response view to all response types
65a84fa
notmedia added a commit that referenced this issue Dec 12, 2022
@notmedia
fix(#28): add info why client/bidirectional streaming is not allowed
3e52e3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
getezy
Status: Done
Milestone
v1-beta.14
Development

No branches or pull requests
2 participants
@mishushakov @notmedia