Skip to content

fix: Empty fields required #289

fix: Empty fields required

fix: Empty fields required #289

You are viewing an older attempt in the history of this workflow run. View latest attempt.
Triggered via pull request April 2, 2024 19:45
Status Failure
Total duration 3m 8s
Artifacts

code-quality.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 2 warnings
this boolean expression can be simplified: crates/core/src/pattern/patterns.rs#L520
error: this boolean expression can be simplified --> crates/core/src/pattern/patterns.rs:520:25 | 520 | / !(node.child_by_field_id(field.id()).is_none() && lang.optional_empty_field_compilation(sort, field.id())) 521 | | // we wanted to be able to match on the presence of parentheses in an arrow function manually 522 | | // using ast_node syntax, but we wanted snippets to match regardless of weather or not the 523 | | // parenthesis are present, so we made the parenthesis a named node within a field, but ... | 538 | | // } 539 | | && !lang.skip_snippet_compilation_of_field(sort, field.id()) | |____________________________________________________________________________________^ help: try: `!(lang.skip_snippet_compilation_of_field(sort, field.id()) || node.child_by_field_id(field.id()).is_none() && lang.optional_empty_field_compilation(sort, field.id()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `-D clippy::nonminimal-bool` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::nonminimal_bool)]`
clippy_check
Clippy had exited with the 101 exit code
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/