chore: match css property

[ilevyor]

matches css property, closes: #59

Summary by CodeRabbit

• New Features
  • Introduced a new test for validating CSS property values with variables.
  • Added support for a new CSS snippet context to enhance coding efficiency.

[coderabbitai]

Walkthrough

The recent update introduces enhancements to CSS handling, notably in testing CSS property values with variables and expanding snippet context support for CSS. A new test function ensures CSS property values can be effectively tested with variables, while the addition of a snippet context string aims to improve the parsing and understanding of CSS code, especially when dealing with custom properties or variables.

Changes

Files	Change Summaries
.../core/src/test.rs	Added a new test function css_property_value
.../language/src/css.rs	Added "GRIT_BLOCK { GRIT_PROPERTY: " to snippet context strings; Included a test case for variable import

Poem

🎉🐰

In the realm of style and grace,
Where CSS takes its place,
A rabbit hopped, code in tow,
Adding tests and snippets to show.

"For better code," it did proclaim,
"We refine, we test, we aim!"
🌟📜

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c8f9160 and 7b153a5.

Files selected for processing (2)

• crates/core/src/test.rs (1 hunks)
• crates/language/src/css.rs (2 hunks)

Additional comments: 3

crates/language/src/css.rs (2)

• 56-56: The addition of the new snippet context string "GRIT_BLOCK { GRIT_PROPERTY: " is a significant enhancement for handling CSS properties involving variables. However, it's essential to ensure consistency and clarity in the naming and usage of these context strings. Consider adding a comment explaining the specific use case or scenario where this new context string is beneficial. This will help future developers understand its purpose and application within the project.
• 79-89: The test case import_variable is a valuable addition for verifying the handling of CSS variables. It's well-structured and follows good testing practices. However, there are a couple of points to consider for improvement:

1. Test Case Naming: The name import_variable might be slightly misleading since it suggests the test is about importing a variable, whereas it's actually testing the parsing of a CSS variable. Consider renaming it to more accurately reflect the test's purpose, such as parse_css_variable.

2. Assertion Details: While assert!(!nodes.is_empty()); effectively checks that the parsing produces some nodes, it might be beneficial to add more detailed assertions. For example, verifying the specific type of node expected or the content of the node could make the test more robust and informative.

crates/core/src/test.rs (1)

• 12729-12749: The test function css_property_value is well-structured and follows best practices for writing tests. It's clear and concise, making good use of trim_margin().unwrap() for readability. However, consider adding comments to explain the purpose of the test and the significance of the pattern and source being used. This will enhance maintainability and clarity for future contributors.