Skip to content

cmake: Use PUBLIC scope for dependencies #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

cmake: Use PUBLIC scope for dependencies #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ if (REFLECTCPP_USE_BUNDLED_DEPENDENCIES)
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include/rfl/thirdparty>)
else ()
find_package(ctre CONFIG REQUIRED)
target_link_libraries(reflectcpp INTERFACE ctre::ctre)
target_link_libraries(reflectcpp PUBLIC ctre::ctre)
endif ()

if (REFLECTCPP_JSON)
Expand All @@ -93,7 +93,7 @@ if (REFLECTCPP_JSON)
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include/rfl/thirdparty>)
else ()
find_package(yyjson CONFIG REQUIRED)
target_link_libraries(reflectcpp INTERFACE yyjson::yyjson)
target_link_libraries(reflectcpp PUBLIC yyjson::yyjson)
endif ()
endif ()

Expand Down Expand Up @@ -123,7 +123,7 @@ if (REFLECTCPP_FLEXBUFFERS)
src/reflectcpp_flexbuf.cpp
)
find_package(flatbuffers CONFIG REQUIRED)
target_link_libraries(reflectcpp INTERFACE flatbuffers::flatbuffers)
target_link_libraries(reflectcpp PUBLIC flatbuffers::flatbuffers)
endif ()

if (REFLECTCPP_MSGPACK)
Expand Down Expand Up @@ -162,15 +162,15 @@ if (REFLECTCPP_XML)
src/reflectcpp_xml.cpp
)
find_package(pugixml CONFIG REQUIRED)
target_link_libraries(reflectcpp INTERFACE pugixml::pugixml)
target_link_libraries(reflectcpp PUBLIC pugixml::pugixml)
endif ()

if (REFLECTCPP_YAML)
list(APPEND REFLECT_CPP_SOURCES
src/reflectcpp_yaml.cpp
)
find_package(yaml-cpp CONFIG REQUIRED)
target_link_libraries(reflectcpp INTERFACE yaml-cpp::yaml-cpp)
target_link_libraries(reflectcpp PUBLIC yaml-cpp::yaml-cpp)
endif ()

set_target_properties(reflectcpp PROPERTIES LINKER_LANGUAGE CXX)
Expand All @@ -187,7 +187,7 @@ endif ()
if (REFLECTCPP_BUILD_BENCHMARKS)
find_package(benchmark CONFIG REQUIRED)
find_package(simdjson CONFIG REQUIRED)
target_link_libraries(reflectcpp INTERFACE benchmark::benchmark simdjson::simdjson)
target_link_libraries(reflectcpp PUBLIC benchmark::benchmark simdjson::simdjson)
add_subdirectory(benchmarks)
endif ()

Expand Down
Loading