Short label and guidance hint #253

florianm · 2021-11-04T02:24:50Z

Fixes deployment errors as discussed on Slack:

Fix: short is a reserved JS keyword, use dict['short'] instead of dict.short syntax. (thanks @issa-tseng)
Fix: Patch ES6 parameter defaults (Thanks Tom)
Improve: Made old forms robust against absence of short label and guidance hint.
Noop: Works with PR 18 to build2xlsform, but needs manual changing of language (ODK Build generates default language "English") to include language code (e.g. "English (en)") and XLSForms doesn't support short label yet
Test: Test report of running this locally
Docs: Updated CONTRIBUTING docs to include debugging steps for individual JS assets (Thanks Tom)

* Timestamped form slug becomes now form version * Sanitized form title component of form slug becomes form id * Updated deps in Gemfile

* Fixed parameter defaults (ES6 style does not compile) * Fixed incorrect use of "short" as variable name, using "shortlabel" instead througout * Fixed non-existing translations for guidance and shortlabel * INCORRECT: output now has "shortlabel" instead of "short" - need to replace or patch

* short is a protected word in JS * use `dict[short]` syntax over `dict.short`

* Code comments now correctly reference support for "short" * Contrib guide contains some examples of compilation issues

yanokwa

LGTM (and to @smoyth)

Florian Mayer and others added 12 commits December 2, 2020 11:37

improve: Export form id and version

e0646d5

* Timestamped form slug becomes now form version * Sanitized form title component of form slug becomes form id * Updated deps in Gemfile

bug: revert Gemfile.lock to master

629b79f

fix: use only the hashed timestamp as version, drop prefix and title

cfc55a9

Fix version: must be a string, not a number

19a7422

Update slug

f8c0857

merge upstream/master

47705e8

docs: Improve wording of BUILDING.md

ad204ba

docs: Add debugging steps to CONTRIBUTING.md

c81b1a2

noop: Update dev dependency yui-compressor

399339e

Fix short label

b8fabff

* short is a protected word in JS * use `dict[short]` syntax over `dict.short`

Fix code comments, improve contributing guide

ba3872e

* Code comments now correctly reference support for "short" * Contrib guide contains some examples of compilation issues

yanokwa approved these changes Nov 9, 2021

View reviewed changes

yanokwa merged commit d369d92 into getodk:master Nov 9, 2021

florianm deleted the short-guidance branch January 9, 2022 05:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Short label and guidance hint #253

Short label and guidance hint #253

florianm commented Nov 4, 2021 •

edited

Loading

yanokwa left a comment

Short label and guidance hint #253

Short label and guidance hint #253

Conversation

florianm commented Nov 4, 2021 • edited Loading

yanokwa left a comment

Choose a reason for hiding this comment

florianm commented Nov 4, 2021 •

edited

Loading