This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
Use empty string as default for autosend and autodelete #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanokwa
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
LGTM.
I did not confirm this specific PR, but I confirmed that if I export a form to XLS, delete auto_send and auto_delete values (but leave the headers), I get an XML that doesn't have any mention of auto_send or auto_delete and so will default to Collect's settings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #319
Changes defaults of both autosend and autodelete from the incorrect
"default"to an empty string"".It appears that my IDE has also deleted some trailing whitespaces.