Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: Also pass along a state (nonce) paramater. #1135

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

improve: Also pass along a state (nonce) paramater. #1135

wants to merge 4 commits into from

Commits on May 1, 2024

  1. improve: Also pass along a state (nonce) paramater. 

    bug: getodk#1134

It's not needed for CSRF protection because code_challenge does this, but the Authentik IDP will return &state= in the query string.  This will trigger node-openid-client to fail a check.
    @openbrian
    openbrian committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6776bab View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Explain why the nonce (state) is sent.

    @openbrian
    openbrian committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1e416c1 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. PKCS -> PKCE

    @openbrian
    openbrian committed May 4, 2024
    Configuration menu
    Copy the full SHA
    4cfd3ec View commit details
    Browse the repository at this point in the history

  2. Use default generated nonce length of 32.

    @openbrian
    openbrian committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5ecc86d View commit details
    Browse the repository at this point in the history