Fix bug with insertMany, createdAt, and entity timestamp #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
approved these changes
Jun 6, 2024
| @@ -27,7 +27,7 @@ class Entity extends Frame.define( | |||
| 'int4', 'int4', | |||
| 'conflictType', | |||
| 'timestamptz', | |||
| 'timestamptz', 'timestampz', | |||
| 'timestamptz', 'timestamptz', | |||
There was a problem hiding this comment.
the comment before the class definition has became obsolete - not by this change though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this after adding a property to the Entity frame and then trying to "insertMany" entities.
It's not the
createdAttimestamp type that gets rearranged in the insertMany query, it's the last type becauseindexOf(['createdAt'], Type.insertfields(with the brackets) always returns -1.indexOf('createdAt',...works as intended. Fixing this also led me to fix the typo oftimestampzin the Entity frame that wasn't being surfaced before.What has been done to verify that this works as intended?
Added a new test, which I verified failed before the code change.
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I don't think there was previously a scenario to trigger this bug before. It didn't come up if the last type in a Frame was a timestamp, or if the Frame didn't have a createdAt.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes